refactor DeletedMessageGroups view data handling into a store #2692
Conversation
# Conflicts: # src/Frontend/src/stores/MessageStore.ts
| } | ||
| watch(autoRefreshValue, (newValue) => { | ||
| updateInterval(newValue || 0); |
There was a problem hiding this comment.
Given that you modified updateInterval to do the pause and resume as part of the internals, I don't think we need the if/else statement at all here.
There was a problem hiding this comment.
without the if statement, there would be nothing to call start when going from 0 to >0. This has made me realise, however, that the updateInterval will potentially resume before start is ever called
src/Frontend/src/components/failedmessages/DeletedMessageGroups.vue
Outdated
Show resolved
Hide resolved
| constructor(store?: ServiceControlStore) { | ||
| //this module is only called from within view setup or other pinia stores, so this call is lifecycle safe | ||
| this.serviceControlStore = useServiceControlStore(); | ||
| this.serviceControlStore = store ?? useServiceControlStore(); |
There was a problem hiding this comment.
Given useServiceControlStore() is a singleton, do we need to pass it in?
There was a problem hiding this comment.
it's not a singleton, but pinia ensures that the same store is injected for each call. This seems safer, given we don't control where in the lifecycle this class is constructed
| watch(isRefreshing, () => { | ||
| // If we're currently polling at 5 seconds and there is a restore in progress, then change the polling interval to poll every 1 second | ||
| if (!pollingFaster && isRestoreInProgress()) { | ||
| pollingFaster = true; | ||
| updateInterval(1000); | ||
| } else if (pollingFaster && !isRestoreInProgress()) { | ||
| // if we're currently polling every 1 second and all restores are done, change polling frequency back to every 5 seconds | ||
| pollingFaster = false; | ||
| updateInterval(5000); | ||
| } | ||
| }); |
There was a problem hiding this comment.
Something feels off here. Why are we updating the interval on the isRefreshing watch?
The interval is already updated when we call restoreGroup.
src/Frontend/src/components/failedmessages/DeletedMessageGroups.vue
Outdated
Show resolved
Hide resolved
part of #1905, extending #2675 to remove direct SC calls from views