Skip to content

Conversation

@WojcikMike
Copy link
Contributor

@WojcikMike WojcikMike commented Jun 21, 2016

Who's affected

  • Every ServicePulse user that has more than 1000 items in failed queues, endpoints, groups etc.

Symptoms

The lack of formatting makes it hard to read bigger numbers. This change introduce tousand separator to ease the reading

Original bug report

Number formatting

@WojcikMike WojcikMike self-assigned this Jun 21, 2016
@WojcikMike
Copy link
Contributor Author

fixes #261

Uses default angularjs number formatting (US format). For supporting different cultures one need to follow this: http://stackoverflow.com/questions/23409939/angular-js-decimal-numbers-in-european-notation

ping: @Particular/servicepulse-maintainers

@WojcikMike WojcikMike added this to the 1.6.5 milestone Jun 21, 2016
@WojcikMike WojcikMike added the Type: Bug Type: Bug label Jun 21, 2016
@WilliamBZA
Copy link
Member

👍 LGTM.

@WilliamBZA WilliamBZA merged commit d2c7c1c into master Jun 21, 2016
@WilliamBZA WilliamBZA deleted the add_number_formatting branch June 21, 2016 11:21
@WojcikMike WojcikMike mentioned this pull request Jun 21, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Type: Bug Type: Bug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants