Allow selection of group classifier #386
Conversation
|
LGTM |
|
NB: This should only be merged and released once SC 1.27.0 has been released. Marking as [WIP] until then. |
WilliamBZA
changed the title
|
|
||
| <div class="row"> | ||
| <div class="col-sm-12" ng-show="vm.exceptionGroups.length > 0"> | ||
| <div class="row" ng-show="vm.availableClassifiers.length && vm.exceptionGroups.length"> |
There was a problem hiding this comment.
This condition means that if we switch to classification that has no groups we won't be able to go back, right?
I think we should remove vm.exceptionGroups.length part.
There was a problem hiding this comment.
Good catch. I've updated.
WilliamBZA
changed the title
|
Changed from [WIP] to ready as SC has been released. @tmasternak We just need the release notes now and we can release this. |
|
@WilliamBZA considering final version we have chosen for SC (reusing the already existing classifications) I don't think it's no longer critical to release SP ASAP. In other words this could be bundled with next SP release when maintainers decide to do a release. /cc: @mikeminutillo |
Adds support for displaying groups displayed by different classifications.
Addresses: #239
Addresses: https://github.com/Particular/PlatformDevelopment/issues/1038
Ping @Particular/servicepulse-maintainers, @janovesk, @mikeminutillo, @SzymonPobiega, @tmasternak, @boblangley