Allow deep-linking to failed message groups #399
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WojcikMike
suggested changes
Feb 3, 2017
Contributor
There was a problem hiding this comment.
Code LGTM but, it doesn't work :). When I open a new browser window (in-private) and I try to paste a URL: http://localhost:8081/#/failedMessages/1195d590-ed28-907c-07da-85bf687b3c22 I am redirected to main dashboard. And later on I can't select any group even by clicking on a failed message group
It turned out to be browser cache issue. So after clearing a cache it works well. The only issue that when one navigates to such site the message count is incorrect ( 0 messages in group)
WilliamBZA
force-pushed
the
group-deep-linking
branch
from
40e7b4c to
7b09a46
Compare
Member
Author
|
Pretty eagle-eyed there @WojcikMike. Fixed. |
WojcikMike
approved these changes
Feb 3, 2017
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows for deep linking to failed message groups. This will provide users the ability to bookmark failed groups, or to send links to other people so that they can navigate directly tot he failed groups.
Connects to: #394
Ping @Particular/servicepulse-maintainers for review.