Skip to content

Stop using javascript:// #636

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 30, 2018
Merged

Stop using javascript:// #636

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/ServicePulse.Host/app/js/directives/ui.particular.redirectLink.tpl.html
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,10 +1,10 @@
<span class="version-info">
<span ng-hide="redirect">
<i class="fa pa-redirect-source pa-redirect-small" uib-tooltip="Redirect"></i>
No redirect (<a href="javascript://" ng-click="createRedirect()">create</a>)
No redirect (<a href="#" ng-click="$event.preventDefault();createRedirect()">create</a>)
</span>
<span ng-show="redirect" uib-tooltip="{{redirect.to_physical_address}}">
<i class="fa pa-redirect-source pa-redirect-small" uib-tooltip="Redirect"></i>
Redirect: {{redirect.to_physical_address}} (<a href="javascript://" ng-click="editRedirect(redirect)">modify</a>)
Redirect: {{redirect.to_physical_address}} (<a href="#" ng-click="$event.preventDefault();editRedirect(redirect)">modify</a>)
</span>
</span>
8 changes: 4 additions & 4 deletions src/ServicePulse.Host/app/js/views/archive/view.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,16 +16,16 @@
</button>
<ul class="dropdown-menu">
<li>
<a href="javascript://" ng-click="vm.selectTimeGroup()"><span class="fa fa-calendar" aria-hidden="true"></span> All Archived</a>
<a href="#" ng-click="$event.preventDefault();vm.selectTimeGroup()"><span class="fa fa-calendar" aria-hidden="true"></span> All Archived</a>
</li>
<li>
<a href="javascript://" ng-click="vm.selectTimeGroup('2', 'hours')"><span class="fa fa-calendar" aria-hidden="true"></span> Archived in the last 2 Hours</a>
<a href="#" ng-click="$event.preventDefault();vm.selectTimeGroup('2', 'hours')"><span class="fa fa-calendar" aria-hidden="true"></span> Archived in the last 2 Hours</a>
</li>
<li>
<a href="javascript://" ng-click="vm.selectTimeGroup('1', 'days')"><span class="fa fa-calendar" aria-hidden="true"></span> Archived in the last 1 Day</a>
<a href="#" ng-click="$event.preventDefault();vm.selectTimeGroup('1', 'days')"><span class="fa fa-calendar" aria-hidden="true"></span> Archived in the last 1 Day</a>
</li>
<li>
<a href="javascript://" ng-click="vm.selectTimeGroup('7', 'days')"><span class="fa fa-calendar " aria-hidden="true"></span> Archived in the last 7 Days</a>
<a href="#" ng-click="$event.preventDefault();vm.selectTimeGroup('7', 'days')"><span class="fa fa-calendar " aria-hidden="true"></span> Archived in the last 7 Days</a>
</li>
</ul>
</div>
Expand Down
2 changes: 1 addition & 1 deletion src/ServicePulse.Host/app/js/views/failed_groups/view.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,7 +57,7 @@ <h6>Failed message groups</h6>
</button>
<ul class="dropdown-menu">
<li ng-repeat="classifier in vm.availableClassifiers">
<a href="javascript://" ng-click="vm.selectClassification(classifier)">{{classifier}}</a>
<a href="#" ng-click="$event.preventDefault();vm.selectClassification(classifier)">{{classifier}}</a>
</li>
</ul>
</div>
Expand Down
8 changes: 4 additions & 4 deletions src/ServicePulse.Host/app/js/views/failed_messages/view.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,16 +41,16 @@ <h3 class="active group-title group-message-count">{{vm.selectedExceptionGroup.c
</button>
<ul class="dropdown-menu">
<li>
<a href="javascript://" ng-click="vm.selectGroup(vm.selectedExceptionGroup, 'message_type', 'asc')"><span class="glyphicon glyphicon-sort-by-alphabet" aria-hidden="true"></span> Message Type (ascending)</a>
<a href="#" ng-click="$event.preventDefault();vm.selectGroup(vm.selectedExceptionGroup, 'message_type', 'asc')"><span class="glyphicon glyphicon-sort-by-alphabet" aria-hidden="true"></span> Message Type (ascending)</a>
</li>
<li>
<a href="javascript://" ng-click="vm.selectGroup(vm.selectedExceptionGroup, 'message_type', 'desc')"><span class="glyphicon glyphicon-sort-by-alphabet-alt" aria-hidden="true"></span> Message Type (descending)</a>
<a href="#" ng-click="$event.preventDefault();vm.selectGroup(vm.selectedExceptionGroup, 'message_type', 'desc')"><span class="glyphicon glyphicon-sort-by-alphabet-alt" aria-hidden="true"></span> Message Type (descending)</a>
</li>
<li>
<a href="javascript://" ng-click="vm.selectGroup(vm.selectedExceptionGroup, 'time_of_failure', 'asc')"><span class="glyphicon glyphicon-sort-by-alphabet" aria-hidden="true"></span> Time Of Failure (ascending)</a>
<a href="#" ng-click="$event.preventDefault();vm.selectGroup(vm.selectedExceptionGroup, 'time_of_failure', 'asc')"><span class="glyphicon glyphicon-sort-by-alphabet" aria-hidden="true"></span> Time Of Failure (ascending)</a>
</li>
<li>
<a href="javascript://" ng-click="vm.selectGroup(vm.selectedExceptionGroup, 'time_of_failure', 'desc')"><span class="glyphicon glyphicon-sort-by-alphabet-alt" aria-hidden="true"></span> Time Of Failure (descending)</a>
<a href="#" ng-click="$event.preventDefault();vm.selectGroup(vm.selectedExceptionGroup, 'time_of_failure', 'desc')"><span class="glyphicon glyphicon-sort-by-alphabet-alt" aria-hidden="true"></span> Time Of Failure (descending)</a>
</li>
</ul>
</div>
Expand Down
12 changes: 6 additions & 6 deletions src/ServicePulse.Host/app/js/views/pending_retries/view.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,22 +61,22 @@
</button>
<ul class="dropdown-menu pull-right">
<li>
<a href="javascript://" ng-click="vm.selectGroup('message_type', 'asc')"><span class="fa fa-long-arrow-down" aria-hidden="true"></span> Message Type</a>
<a href="#" ng-click="$event.preventDefault();vm.selectGroup('message_type', 'asc')"><span class="fa fa-long-arrow-down" aria-hidden="true"></span> Message Type</a>
</li>
<li>
<a href="javascript://" ng-click="vm.selectGroup('message_type', 'desc')"><span class="fa fa-long-arrow-up" aria-hidden="true"></span> Message Type</a>
<a href="#" ng-click="$event.preventDefault();vm.selectGroup('message_type', 'desc')"><span class="fa fa-long-arrow-up" aria-hidden="true"></span> Message Type</a>
</li>
<li>
<a href="javascript://" ng-click="vm.selectGroup('time_of_failure', 'asc')"><span class="fa fa-long-arrow-down" aria-hidden="true"></span> Time Of Failure</a>
<a href="#" ng-click="$event.preventDefault();vm.selectGroup('time_of_failure', 'asc')"><span class="fa fa-long-arrow-down" aria-hidden="true"></span> Time Of Failure</a>
</li>
<li>
<a href="javascript://" ng-click="vm.selectGroup('time_of_failure', 'desc')"><span class="fa fa-long-arrow-up" aria-hidden="true"></span> Time Of Failure</a>
<a href="#" ng-click="$event.preventDefault();vm.selectGroup('time_of_failure', 'desc')"><span class="fa fa-long-arrow-up" aria-hidden="true"></span> Time Of Failure</a>
</li>
<li>
<a href="javascript://" ng-click="vm.selectGroup('last_modified', 'asc')"><span class="fa fa-long-arrow-down" aria-hidden="true"></span> Time Of Retry request</a>
<a href="#" ng-click="$event.preventDefault();vm.selectGroup('last_modified', 'asc')"><span class="fa fa-long-arrow-down" aria-hidden="true"></span> Time Of Retry request</a>
</li>
<li>
<a href="javascript://" ng-click="vm.selectGroup('last_modified', 'desc')"><span class="fa fa-long-arrow-up" aria-hidden="true"></span> Time Of Retry request</a>
<a href="#" ng-click="$event.preventDefault();vm.selectGroup('last_modified', 'desc')"><span class="fa fa-long-arrow-up" aria-hidden="true"></span> Time Of Retry request</a>
</li>
</ul>
</div>
Expand Down