Skip to content

Add tab to url #666

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Oct 29, 2018
Merged

Add tab to url #666

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
7766ec3
Adding information about which tab should be open to URL
WojcikMike Oct 26, 2018
08893d3
Update src/ServicePulse.Host/app/modules/monitoring/js/endpoint_detai…
WilliamBZA Oct 26, 2018
84a84ce
Update src/ServicePulse.Host/app/modules/monitoring/js/endpoint_detai…
WilliamBZA Oct 26, 2018
872c2f6
Update src/ServicePulse.Host/app/modules/monitoring/views/endpoint_de…
WilliamBZA Oct 26, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 10 additions & 2 deletions src/ServicePulse.Host/app/modules/monitoring/js/endpoint_details.controller.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,8 +18,8 @@

$scope.endpointName = $routeParams.endpointName;
$scope.sourceIndex = $routeParams.sourceIndex;
$scope.showInstancesBreakdown = $routeParams.tab === 'instancesBreakdown';
$scope.loading = true;
$scope.showInstancesBreakdown = false;
$scope.largeGraphsMinimumYAxis = largeGraphsMinimumYAxis;
$scope.smallGraphsMinimumYAxis = smallGraphsMinimumYAxis;

Expand All @@ -42,6 +42,14 @@
}
}

$scope.buildUrl = function (selectedPeriodValue, showInstancesBreakdownTab) {
return `#/endpoint_details/${$scope.endpointName}/${$scope.sourceIndex}?historyPeriod=${selectedPeriodValue}&tab=${$scope.showInstancesBreakdown ? 'instancesBreakdown' : 'messageTypeBreakdown'}`;
};

$scope.showInstancesBreakdownTab = function(isVisible) {
$scope.showInstancesBreakdown = isVisible;
};

function updateUI() {
if (subscription) {
subscription.dispose();
Expand Down Expand Up @@ -142,4 +150,4 @@
angular.module('endpoint_details')
.controller('endpointDetailsCtrl', controller);

}(window, window.angular));
}(window, window.angular));
6 changes: 3 additions & 3 deletions src/ServicePulse.Host/app/modules/monitoring/views/endpoint_details.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ <h1 class="righ-side-ellipsis col-lg-max-10" uib-tooltip="{{endpointName}}">
<div class="col-sm-3 no-side-padding toolbar-menus">
<ul class="nav nav-pills period-selector">
<li role="presentation" ng-repeat="period in periods" ng-class="(period.value == selectedPeriod.value ? 'active' : 'notselected')">
<a ng-click="selectPeriod(period)" href="#/endpoint_details/{{endpointName}}/{{sourceIndex}}?historyPeriod={{period.value}}">{{period.text}}</a>
<a ng-click="selectPeriod(period)" ng-href="{{buildUrl(period.value)}}">{{period.text}}</a>
</li>
</ul>
</div>
Expand Down Expand Up @@ -202,10 +202,10 @@ <h1 class="righ-side-ellipsis col-lg-max-10" uib-tooltip="{{endpointName}}">
<busy ng-show="loading" message="Loading details"></busy>
<div class="tabs">
<h5 ng-class="{active: !showInstancesBreakdown}">
<a ng-click="showInstancesBreakdown = false" class="ng-binding">Message Types</a>
<a ng-click="showInstancesBreakdownTab(false)" ng-href="{{buildUrl(selectedPeriod.value, 'messageTypeBreakdown')}}" class="ng-binding">Message Types</a>
</h5>
<h5 ng-class="{active: showInstancesBreakdown}">
<a ng-click="showInstancesBreakdown = true" class="ng-binding">Instances</a>
<a ng-click="showInstancesBreakdownTab(true)" ng-href="{{buildUrl(selectedPeriod.value, 'instancesBreakdown')}}" class="ng-binding">Instances</a>
</h5>
</div>

Expand Down