Skip to content

Add storing of group by in URL #682

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 19, 2018
Merged

Add storing of group by in URL #682

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 10 additions & 3 deletions src/ServicePulse.Host/app/js/views/failed_groups/controller.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,8 @@
notifyService,
serviceControlService,
failedMessageGroupsService,
toastService) {
toastService,
$routeParams) {

var vm = this;
var notifier = notifyService();
Expand Down Expand Up @@ -164,7 +165,12 @@
$cookies.put("failed_groups_classification", classification);
};

var getDefaultClassification = function(classifiers) {
var getDefaultClassification = function (classifiers) {
if ($routeParams.groupBy) {
saveSelectedClassification($routeParams.groupBy);
return $routeParams.groupBy;
}

var storedClassification = $cookies.get("failed_groups_classification");

if (typeof storedClassification === "undefined") {
Expand Down Expand Up @@ -378,7 +384,8 @@
"notifyService",
"serviceControlService",
"failedMessageGroupsService",
"toastService"
"toastService",
'$routeParams'
];

angular.module("sc")
Expand Down
2 changes: 1 addition & 1 deletion src/ServicePulse.Host/app/js/views/failed_groups/view.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,7 @@ <h6>Failed message groups</h6>
</button>
<ul class="dropdown-menu">
<li ng-repeat="classifier in vm.availableClassifiers">
<a href="#" ng-click="$event.preventDefault();vm.selectClassification(classifier)">{{classifier}}</a>
<a href="/#/failed-messages/groups?groupBy={{classifier}}">{{classifier}}</a>
</li>
</ul>
</div>
Expand Down