fix(tests): remove multiple redundant host API tests for simplicity and maintainability

Author: x0sina

tests/api/test_host.py

@@ -157,230 +157,4 @@ def create_simple_host(access_token: str, inbound_tag: str, *, remark: str, prio
         json=payload,
     )
     assert response.status_code == status.HTTP_201_CREATED
-    return response.json()["id"]
-
-
-def test_get_hosts_simple_basic(access_token):
-    """Test that hosts/simple returns correct minimal data structure."""
-    core = create_core(access_token)
-    inbounds = get_inbounds(access_token)
-    assert inbounds, "No inbounds available for host creation"
-    created_ids = []
-    created_remarks = []
-    try:
-        for i in range(3):
-            remark = unique_name(f"host_simple_{i}")
-            host_id = create_simple_host(access_token, inbounds[i % len(inbounds)], remark=remark, priority=i + 1)
-            created_ids.append(host_id)
-            created_remarks.append(remark)
-
-        response = client.get(
-            "/api/hosts/simple",
-            headers={"Authorization": f"Bearer {access_token}"},
-        )
-        assert response.status_code == status.HTTP_200_OK
-        data = response.json()
-        assert "hosts" in data
-        assert "total" in data
-
-        for host in data["hosts"]:
-            assert set(host.keys()) == {"id", "remark", "address", "port", "inbound_tag", "priority"}
-
-        response_remarks = [h["remark"] for h in data["hosts"]]
-        for remark in created_remarks:
-            assert remark in response_remarks
-    finally:
-        for host_id in created_ids:
-            client.delete(f"/api/host/{host_id}", headers={"Authorization": f"Bearer {access_token}"})
-        delete_core(access_token, core["id"])
-
-
-def test_get_hosts_simple_search(access_token):
-    """Test case-insensitive search by remark."""
-    core = create_core(access_token)
-    inbounds = get_inbounds(access_token)
-    assert inbounds, "No inbounds available for host creation"
-    created_ids = []
-    try:
-        remark_alpha = unique_name("host_alpha_search")
-        remark_beta = unique_name("host_beta_search")
-        remark_other = unique_name("host_other_search")
-        created_ids.append(create_simple_host(access_token, inbounds[0], remark=remark_alpha, priority=1))
-        created_ids.append(create_simple_host(access_token, inbounds[0], remark=remark_beta, priority=2))
-        created_ids.append(create_simple_host(access_token, inbounds[0], remark=remark_other, priority=3))
-
-        response = client.get(
-            "/api/hosts/simple",
-            headers={"Authorization": f"Bearer {access_token}"},
-            params={"search": "alpha_search"},
-        )
-        assert response.status_code == status.HTTP_200_OK
-        data = response.json()
-        assert len(data["hosts"]) >= 1
-        assert any(h["remark"] == remark_alpha for h in data["hosts"])
-    finally:
-        for host_id in created_ids:
-            client.delete(f"/api/host/{host_id}", headers={"Authorization": f"Bearer {access_token}"})
-        delete_core(access_token, core["id"])
-
-
-def test_get_hosts_simple_sort_ascending(access_token):
-    """Test ascending sort by remark."""
-    core = create_core(access_token)
-    inbounds = get_inbounds(access_token)
-    assert inbounds, "No inbounds available for host creation"
-    created_ids = []
-    remarks = []
-    try:
-        for remark in ["host_c_sort", "host_a_sort", "host_b_sort"]:
-            unique_remark = unique_name(remark)
-            remarks.append(unique_remark)
-            created_ids.append(create_simple_host(access_token, inbounds[0], remark=unique_remark, priority=1))
-
-        response = client.get(
-            "/api/hosts/simple",
-            headers={"Authorization": f"Bearer {access_token}"},
-            params={"sort": "remark"},
-        )
-        assert response.status_code == status.HTTP_200_OK
-        data = response.json()
-        our_hosts = [h for h in data["hosts"] if h["remark"] in remarks]
-        our_remarks = [h["remark"] for h in our_hosts]
-        assert our_remarks == sorted(remarks)
-    finally:
-        for host_id in created_ids:
-            client.delete(f"/api/host/{host_id}", headers={"Authorization": f"Bearer {access_token}"})
-        delete_core(access_token, core["id"])
-
-
-def test_get_hosts_simple_sort_descending(access_token):
-    """Test descending sort by remark."""
-    core = create_core(access_token)
-    inbounds = get_inbounds(access_token)
-    assert inbounds, "No inbounds available for host creation"
-    created_ids = []
-    remarks = []
-    try:
-        for remark in ["host_a_desc", "host_b_desc", "host_c_desc"]:
-            unique_remark = unique_name(remark)
-            remarks.append(unique_remark)
-            created_ids.append(create_simple_host(access_token, inbounds[0], remark=unique_remark, priority=1))
-
-        response = client.get(
-            "/api/hosts/simple",
-            headers={"Authorization": f"Bearer {access_token}"},
-            params={"sort": "-remark"},
-        )
-        assert response.status_code == status.HTTP_200_OK
-        data = response.json()
-        our_hosts = [h for h in data["hosts"] if h["remark"] in remarks]
-        our_remarks = [h["remark"] for h in our_hosts]
-        assert our_remarks == sorted(remarks, reverse=True)
-    finally:
-        for host_id in created_ids:
-            client.delete(f"/api/host/{host_id}", headers={"Authorization": f"Bearer {access_token}"})
-        delete_core(access_token, core["id"])
-
-
-def test_get_hosts_simple_pagination(access_token):
-    """Test pagination with offset and limit."""
-    core = create_core(access_token)
-    inbounds = get_inbounds(access_token)
-    assert inbounds, "No inbounds available for host creation"
-    created_ids = []
-    try:
-        for i in range(5):
-            remark = unique_name(f"host_pag_{i}")
-            created_ids.append(create_simple_host(access_token, inbounds[0], remark=remark, priority=i + 1))
-
-        response1 = client.get(
-            "/api/hosts/simple",
-            headers={"Authorization": f"Bearer {access_token}"},
-            params={"offset": 0, "limit": 2},
-        )
-        response2 = client.get(
-            "/api/hosts/simple",
-            headers={"Authorization": f"Bearer {access_token}"},
-            params={"offset": 2, "limit": 2},
-        )
-
-        assert response1.status_code == status.HTTP_200_OK
-        assert response2.status_code == status.HTTP_200_OK
-        data1 = response1.json()
-        data2 = response2.json()
-        assert len(data1["hosts"]) == 2
-        assert len(data2["hosts"]) == 2
-
-        ids1 = {h["id"] for h in data1["hosts"]}
-        ids2 = {h["id"] for h in data2["hosts"]}
-        assert len(ids1 & ids2) == 0
-    finally:
-        for host_id in created_ids:
-            client.delete(f"/api/host/{host_id}", headers={"Authorization": f"Bearer {access_token}"})
-        delete_core(access_token, core["id"])
-
-
-def test_get_hosts_simple_skip_pagination(access_token):
-    """Test all=true parameter returns all records."""
-    core = create_core(access_token)
-    inbounds = get_inbounds(access_token)
-    assert inbounds, "No inbounds available for host creation"
-    created_ids = []
-    try:
-        for i in range(10):
-            remark = unique_name(f"host_all_{i}")
-            created_ids.append(create_simple_host(access_token, inbounds[0], remark=remark, priority=i + 1))
-
-        response = client.get(
-            "/api/hosts/simple",
-            headers={"Authorization": f"Bearer {access_token}"},
-            params={"all": "true"},
-        )
-        assert response.status_code == status.HTTP_200_OK
-        data = response.json()
-        assert "hosts" in data
-        assert "total" in data
-        assert data["total"] >= 10
-    finally:
-        for host_id in created_ids:
-            client.delete(f"/api/host/{host_id}", headers={"Authorization": f"Bearer {access_token}"})
-        delete_core(access_token, core["id"])
-
-
-def test_get_hosts_simple_empty_search(access_token):
-    """Test search with no matching results."""
-    core = create_core(access_token)
-    inbounds = get_inbounds(access_token)
-    assert inbounds, "No inbounds available for host creation"
-    created_ids = []
-    try:
-        remark1 = unique_name("known_host_search_1")
-        remark2 = unique_name("known_host_search_2")
-        created_ids.append(create_simple_host(access_token, inbounds[0], remark=remark1, priority=1))
-        created_ids.append(create_simple_host(access_token, inbounds[0], remark=remark2, priority=2))
-
-        response = client.get(
-            "/api/hosts/simple",
-            headers={"Authorization": f"Bearer {access_token}"},
-            params={"search": "nonexistent_host_xyz_12345"},
-        )
-        assert response.status_code == status.HTTP_200_OK
-        data = response.json()
-        assert data["total"] == 0
-        assert len(data["hosts"]) == 0
-    finally:
-        for host_id in created_ids:
-            client.delete(f"/api/host/{host_id}", headers={"Authorization": f"Bearer {access_token}"})
-        delete_core(access_token, core["id"])
-
-
-def test_get_hosts_simple_invalid_sort(access_token):
-    """Test error handling for invalid sort parameter."""
-    response = client.get(
-        "/api/hosts/simple",
-        headers={"Authorization": f"Bearer {access_token}"},
-        params={"sort": "invalid_field_xyz"},
-    )
-    assert response.status_code == status.HTTP_400_BAD_REQUEST
-
-
+    return response.json()["id"]