refactor: optimize bulk update logic (ignoring enabling enables and disabling disables)

Author: x0sina

app/operation/admin.py

@@ -382,19 +382,21 @@ async def bulk_set_admins_disabled(
         for db_admin in db_admins:
             await self._ensure_can_change_admin_status(db_admin, current_admin, is_disabled=is_disabled)
 
-        for db_admin in db_admins:
+        admins_to_update = [db_admin for db_admin in db_admins if db_admin.is_disabled != is_disabled]
+
+        for db_admin in admins_to_update:
             db_admin.is_disabled = is_disabled
 
         await db.commit()
 
-        for db_admin in db_admins:
+        for db_admin in admins_to_update:
             modified_admin = AdminDetails.model_validate(db_admin)
             asyncio.create_task(notification.modify_admin(modified_admin, current_admin.username))
             logger.info(
                 f'Admin "{db_admin.username}" bulk {"disabled" if is_disabled else "enabled"} by admin "{current_admin.username}"'
             )
 
-        return self._build_bulk_action_response(db_admins)
+        return self._build_bulk_action_response(admins_to_update)
 
     async def bulk_reset_admins_usage(
         self, db: AsyncSession, bulk_admins: BulkAdminSelection, admin: AdminDetails

app/operation/group.py

@@ -199,27 +199,30 @@ async def bulk_set_groups_disabled(
         for group_id in bulk_groups.ids:
             db_groups.append(await self.get_validated_group(db, group_id))
 
-        for db_group in db_groups:
+        groups_to_update = [db_group for db_group in db_groups if db_group.is_disabled != is_disabled]
+
+        for db_group in groups_to_update:
             db_group.is_disabled = is_disabled
 
         await db.commit()
 
-        for db_group in db_groups:
+        for db_group in groups_to_update:
             await db.refresh(db_group)
             await load_group_attrs(db_group)
 
-        users = await get_users(
-            db,
-            group_ids=[group.id for group in db_groups],
-            status=[UserStatus.active, UserStatus.on_hold],
-        )
-        await sync_users(users)
+        if groups_to_update:
+            users = await get_users(
+                db,
+                group_ids=[group.id for group in groups_to_update],
+                status=[UserStatus.active, UserStatus.on_hold],
+            )
+            await sync_users(users)
 
-        for db_group in db_groups:
+        for db_group in groups_to_update:
             group = GroupResponse.model_validate(db_group)
             asyncio.create_task(notification.modify_group(group, admin.username))
             logger.info(
                 f'Group "{db_group.name}" bulk {"disabled" if is_disabled else "enabled"} by admin "{admin.username}"'
             )
 
-        return self._build_bulk_action_response(db_groups)
+        return self._build_bulk_action_response(groups_to_update)

app/operation/host.py

@@ -167,16 +167,18 @@ async def bulk_set_hosts_disabled(
         for host_id in bulk_hosts.ids:
             db_hosts.append(await self.get_validated_host(db, host_id))
 
-        for db_host in db_hosts:
+        hosts_to_update = [db_host for db_host in db_hosts if db_host.is_disabled != is_disabled]
+
+        for db_host in hosts_to_update:
             db_host.is_disabled = is_disabled
 
         await db.commit()
 
-        for db_host in db_hosts:
+        for db_host in hosts_to_update:
             await db.refresh(db_host)
             host = BaseHost.model_validate(db_host)
             asyncio.create_task(notification.modify_host(host, admin.username))
             await host_manager.add_host(db, db_host)
             logger.info(f'Host "{db_host.id}" bulk {"disabled" if is_disabled else "enabled"} by admin "{admin.username}"')
 
-        return self._build_bulk_action_response(db_hosts)
+        return self._build_bulk_action_response(hosts_to_update)

app/operation/node.py

@@ -954,17 +954,18 @@ async def bulk_set_nodes_status(
         status: NodeStatus,
     ) -> BulkNodesActionResponse:
         db_nodes = await self._get_validated_nodes(db, bulk_nodes.ids)
+        nodes_to_update = [db_node for db_node in db_nodes if db_node.status != status]
 
-        for db_node in db_nodes:
+        for db_node in nodes_to_update:
             payload = self._build_node_modify_payload(db_node)
             payload.status = status
             await self.modify_node(db, node_id=db_node.id, modified_node=payload, admin=admin)
 
         action = "enabled" if status != NodeStatus.disabled else "disabled"
-        for db_node in db_nodes:
+        for db_node in nodes_to_update:
             logger.info(f'Node "{db_node.name}" bulk {action} by admin "{admin.username}"')
 
-        return self._build_bulk_action_response(db_nodes)
+        return self._build_bulk_action_response(nodes_to_update)
 
     async def bulk_reset_nodes_usage(
         self, db: AsyncSession, bulk_nodes: BulkNodeSelection, admin: AdminDetails

app/operation/user_template.py

@@ -152,12 +152,14 @@ async def bulk_set_user_templates_disabled(
         for template_id in bulk_templates.ids:
             db_templates.append(await self.get_validated_user_template(db, template_id))
 
-        for db_template in db_templates:
+        templates_to_update = [db_template for db_template in db_templates if db_template.is_disabled != is_disabled]
+
+        for db_template in templates_to_update:
             db_template.is_disabled = is_disabled
 
         await db.commit()
 
-        for db_template in db_templates:
+        for db_template in templates_to_update:
             await db.refresh(db_template)
             await load_user_template_attrs(db_template)
             user_template = UserTemplateResponse.model_validate(db_template)
@@ -166,4 +168,4 @@ async def bulk_set_user_templates_disabled(
                 f'User template "{db_template.name}" bulk {"disabled" if is_disabled else "enabled"} by admin "{admin.username}"'
             )
 
-        return self._build_bulk_action_response(db_templates)
+        return self._build_bulk_action_response(templates_to_update)