Skip to content

Commit f2e7f3f

Browse files
committed
fix: update sorting logic to use value prefix for direction
1 parent 2cc0706 commit f2e7f3f

7 files changed

Lines changed: 11 additions & 11 deletions

File tree

app/db/crud/admin.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -46,7 +46,7 @@ def _build_admin_sort_clause(sort_option: AdminSortOption):
4646
AdminSortField.used_traffic: Admin.used_traffic,
4747
}
4848
column = field_map[sort_option.field]
49-
return column.desc() if sort_option.direction == SortDirection.desc else column.asc()
49+
return column.desc() if sort_option.value.startswith("-") else column.asc()
5050

5151

5252
def _build_admin_simple_sort_clause(sort_option: AdminSimpleSortOption):
@@ -55,7 +55,7 @@ def _build_admin_simple_sort_clause(sort_option: AdminSimpleSortOption):
5555
AdminSimpleSortField.username: Admin.username,
5656
}
5757
column = field_map[sort_option.field]
58-
return column.desc() if sort_option.direction == SortDirection.desc else column.asc()
58+
return column.desc() if sort_option.value.startswith("-") else column.asc()
5959

6060

6161
async def get_admin(

app/db/crud/client_template.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -32,7 +32,7 @@ def _build_client_template_simple_sort_clause(sort_option: ClientTemplateSimpleS
3232
ClientTemplateSimpleSortField.template_type: ClientTemplate.template_type,
3333
}
3434
column = field_map[sort_option.field]
35-
return column.desc() if sort_option.direction == SortDirection.desc else column.asc()
35+
return column.desc() if sort_option.value.startswith("-") else column.asc()
3636

3737

3838
async def get_client_template_values(db: AsyncSession) -> dict[str, str]:

app/db/crud/core.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,7 @@ def _build_core_simple_sort_clause(sort_option: CoreSimpleSortOption):
1919
CoreSimpleSortField.created_at: CoreConfig.created_at,
2020
}
2121
column = field_map[sort_option.field]
22-
return column.desc() if sort_option.direction == SortDirection.desc else column.asc()
22+
return column.desc() if sort_option.value.startswith("-") else column.asc()
2323

2424

2525
async def get_core_config_by_id(db: AsyncSession, core_id: int) -> CoreConfig | None:

app/db/crud/group.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
from sqlalchemy import select, func, delete
1+
from sqlalchemy import delete, func, select
22
from sqlalchemy.ext.asyncio import AsyncSession
33
from sqlalchemy.orm import selectinload
44

@@ -28,7 +28,7 @@ def _build_group_simple_sort_clause(sort_option: GroupSimpleSortOption):
2828
GroupSimpleSortField.group_name: Group.name,
2929
}
3030
column = field_map[sort_option.field]
31-
return column.desc() if sort_option.direction == SortDirection.desc else column.asc()
31+
return column.desc() if sort_option.value.startswith("-") else column.asc()
3232

3333

3434
async def get_inbounds_by_tags(db: AsyncSession, tags: list[str]) -> list[ProxyInbound]:

app/db/crud/node.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -44,7 +44,7 @@ def _build_node_simple_sort_clause(sort_option: NodeSimpleSortOption):
4444
NodeSimpleSortField.node_name: Node.name,
4545
}
4646
column = field_map[sort_option.field]
47-
return column.desc() if sort_option.direction == SortDirection.desc else column.asc()
47+
return column.desc() if sort_option.value.startswith("-") else column.asc()
4848

4949

5050
async def load_node_attrs(node: Node):

app/db/crud/user.py

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -265,12 +265,12 @@ def _build_user_sort_clause(sort_option: UserSortOption):
265265

266266
if sort_option.field in field_map:
267267
column = field_map[sort_option.field]
268-
return column.desc() if sort_option.direction == SortDirection.desc else column.asc()
268+
return column.desc() if sort_option.value.startswith("-") else column.asc()
269269

270270
column = nullable_field_map[sort_option.field]
271271
return (
272272
case((column.is_(None), 1), else_=0).asc(),
273-
column.desc() if sort_option.direction == SortDirection.desc else column.asc(),
273+
column.desc() if sort_option.value.startswith("-") else column.asc(),
274274
)
275275

276276

@@ -280,7 +280,7 @@ def _build_user_simple_sort_clause(sort_option: UserSimpleSortOption):
280280
UserSimpleSortField.username: User.username,
281281
}
282282
column = field_map[sort_option.field]
283-
return column.desc() if sort_option.direction == SortDirection.desc else column.asc()
283+
return column.desc() if sort_option.value.startswith("-") else column.asc()
284284

285285

286286
async def get_users(

app/db/crud/user_template.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,7 @@ def _build_user_template_simple_sort_clause(sort_option: UserTemplateSimpleSortO
2323
UserTemplateSimpleSortField.template_name: UserTemplate.name,
2424
}
2525
column = field_map[sort_option.field]
26-
return column.desc() if sort_option.direction == SortDirection.desc else column.asc()
26+
return column.desc() if sort_option.value.startswith("-") else column.asc()
2727

2828

2929
async def load_user_template_attrs(template: UserTemplate):

0 commit comments

Comments
 (0)