This repository was archived by the owner on Jun 3, 2024. It is now read-only.
Moar registries #36
Merged
Moar registries #36
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shedaniel
reviewed
Jan 25, 2020
patchwork-registries/src/main/java/com/patchworkmc/mixin/registries/MixinActivity.java
Outdated
Show resolved
Hide resolved
patchwork-registries/src/main/java/com/patchworkmc/mixin/registries/MixinBiomeSourceType.java
Outdated
Show resolved
Hide resolved
patchwork-registries/src/main/java/com/patchworkmc/mixin/registries/MixinBlockEntityType.java
Outdated
Show resolved
Hide resolved
patchwork-registries/src/main/java/com/patchworkmc/mixin/registries/MixinCarver.java
Outdated
Show resolved
Hide resolved
...hwork-registries/src/main/java/com/patchworkmc/mixin/registries/MixinChunkGeneratorType.java
Outdated
Show resolved
Hide resolved
patchwork-registries/src/main/java/com/patchworkmc/mixin/registries/MixinChunkStatus.java
Outdated
Show resolved
Hide resolved
Member
Author
|
I quickly verified with this mod that the RecipeSerializer works. It has a SpecialRecipeSerializer. |
…into moar-registries � Conflicts: � patchwork-registries/src/main/java/com/patchworkmc/mixin/registries/MixinBiome.java � patchwork-registries/src/main/java/com/patchworkmc/mixin/registries/MixinFeature.java � patchwork-registries/src/main/java/com/patchworkmc/mixin/registries/MixinSurfaceBuilder.java
Member
Author
|
I've mentioned this in discord but I'll mention it here as well to be complete. |
Member
Author
|
I recommend everyone who reviews this to not skip over the |
coderbot16
suggested changes
Jan 26, 2020
Member
coderbot16
left a comment
coderbot16
left a comment
There was a problem hiding this comment.
Please deduplicate all of the RecipeSerializer mixins like how I said on discord
...hwork-registries/src/main/java/net/minecraftforge/fml/client/registry/RenderingRegistry.java
Outdated
Show resolved
Hide resolved
(I swear it wasn't me)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds the pretty much the rest of the Forge exposed registries. This is all that inherit from ForgeRegistryEntry except for the custom Forge registries. It also adds the client-only entity rendering registry.
Probably needs testing. I only really tested SoundEvent but the rest is pretty much the same thing. I'm not too sure if I did the RecipeSerializers right. I'll have to test it.