Skip to content

Iss1105 - Misc user feedback #1106

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Oct 3, 2018
Merged

Iss1105 - Misc user feedback #1106

merged 3 commits into from
Oct 3, 2018

Conversation

@jvwong
Copy link
Member

@jvwong jvwong commented Oct 3, 2018

refs #1105

  • interaction listing and title
  • interaction tooltip link outs

screenshot at oct 03 10-30-52
screenshot at oct 03 10-31-20
screenshot at oct 03 10-31-35

@jvwong jvwong changed the title Iss1105 Iss1105 - Misc user feedback Oct 3, 2018
d2fong
d2fong reviewed Oct 3, 2018
View reviewed changes
src/client/features/interactions/index.js Outdated
h('div.app-bar-branding', [
h(PcLogoLink),
h('div.app-bar-title', sources.join(', ') + ' Interactions')
sources.length === 1 ? h('div.app-bar-title', `Top ${config.MAX_SIF_NODES} interactions involving ${sources[0]}`):
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should we always display max sif nodes config value if there are less nodes than that? e.g. top 25 interactions between mdm2 and tp53 when there are only two actual nodes?

@maxkfranz
Copy link
Member

It's top 25 genes rather than interactions, right?

How about something like this?

n = 1 : Interactions with TP53 and the top 25 genes

For n = 1, we can have up to 25 resultant genes.

n >= 2 : Interactions between TP53, MDM2, and PCNA

For n >= 2, we only ever return the n specified with interactions between them.

@maxkfranz
Copy link
Member

An alternative for n = 1 : TP53 and its interactions with the top 25 genes

@jvwong
Copy link
Member Author

jvwong commented Oct 3, 2018

This one has:

n = 1: 'Interactions between TP53 and top 25 genes'
n >= 2: 'Interactions between TP53, MDM2 and CDKN1A'

@maxkfranz maxkfranz merged commit 045fbd7 into PathwayCommons:development Oct 3, 2018
maxkfranz added a commit that referenced this pull request Oct 3, 2018
@maxkfranz
Add a bit of padding to make pathway links easier to click in the int…
c90628b 
…eraction tooltips

Now that the square parentheses are removed, the links are smaller and harder to click.  By adding padding, each link has a larger hit area.

Ref #1106 #1105
@maxkfranz
Copy link
Member

@jvwong @d2fong I've added some padding to make the link sizes a bit bigger, like they were when they had parentheses. This makes them easier to click.

@d2fong
Copy link
Member

d2fong commented Oct 3, 2018 •
edited
Loading

You are going to have to cherry pick all of these commits to v2.0.0. Thats the release branch.

@maxkfranz @jvwong

@d2fong
Copy link
Member

d2fong commented Oct 3, 2018

@maxkfranz @jvwong

Also don't merge development into v2.0.0. There is stuff in development that shouldn't go into v2.0.0.

maxkfranz added a commit that referenced this pull request Oct 3, 2018
@maxkfranz
Merge pull request #1106 from jvwong/iss1105
f63d181 
Iss1105 - Misc user feedback
maxkfranz added a commit that referenced this pull request Oct 3, 2018
@maxkfranz
Add a bit of padding to make pathway links easier to click in the int…
cce07e0 
…eraction tooltips

Now that the square parentheses are removed, the links are smaller and harder to click.  By adding padding, each link has a larger hit area.

Ref #1106 #1105
@maxkfranz
Copy link
Member

Cherry-picked this PR into v2.0.0

@jvwong jvwong deleted the iss1105 branch October 12, 2018 14:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@d2fong d2fong d2fong left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@jvwong @maxkfranz @d2fong