Skip to content

Initial design model implementation #20

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 11 commits into from
Nov 5, 2020
Merged

Initial design model implementation #20

merged 11 commits into from
Nov 5, 2020

Conversation

@marzn
Copy link
Contributor

@marzn marzn commented Oct 29, 2020

No description provided.

@ghost
Copy link

ghost commented Oct 29, 2020 •
edited by ghost
Loading

DeepCode's analysis on #7753d9 found:

  • ℹ️ 5 minor issues. 👇

Top issues

Description Example fixes
The expression inside info will be computed even if the log level is not high enough for the message to be logged. This will slow the application down in vain. Consider checking the log level before evaluating the expression. Occurrences: 🔧 Example fixes
Catching java.lang.Throwable will also catch JVM internal errors like OutOfMemoryErrors or StackOverflowErrors. This is most likely not the intended behavior and considered a bad practice. Consider catching a less general exception. Occurrences: 🔧 Example fixes
Logger calls should be surrounded by log level guards. Occurrences: 🔧 Example fixes

👉 View analysis in DeepCode’s Dashboard | Configure the bot

@marzn marzn mentioned this pull request Nov 1, 2020
Merged
@marzn marzn requested a review from fakepk November 1, 2020 02:08
@marzn marzn marked this pull request as ready for review November 1, 2020 02:08
@marzn marzn merged commit abdb772 into master Nov 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@fakepk fakepk fakepk approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@marzn @fakepk