Masterthesis/patternauthoring api #7
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…djusted, saveoption adjusted, contentrendering adjusted
…ixed pdflatex execute, fully reworked latexenvironment detection, reworked JSONmapping
# Conflicts: # src/main/java/com/patternpedia/api/rest/controller/PatternController.java
DeepCode's analysis on #c84ee6 found:1 minor issue. Top 3 issues
👉 View analysis in DeepCode’s DashboardEdit DeepCode’s Configurations here |
manuwei
reviewed
May 20, 2020
|
|
||
| // @Transactional (readOnly = false) | ||
| // String renderLatex(String content, int begin, int end, AlgorithmType type); | ||
| } |
Contributor
There was a problem hiding this comment.
Is this commented code still needed for something?
Contributor
|
@mbeisel Can you delete the data.sql files? we've decided to save data in a separate repo (https://github.com/PatternPedia/pattern-atlas-content or https://github.com/PatternPedia/internal-pattern-atlas-content) And our ci tests still fail.... |
…nauthoringAPI # Conflicts: # src/test/resources/application.properties
manuwei
approved these changes
May 28, 2020
… already rendered latex code snippets
…onComments in the Database
…mment transfer algorithm. Adjust api calls to kebab-case
|
👉 View analysis in DeepCode’s Dashboard | Configure the bot |
Contributor
|
@mbeisel can you fix the critical issue the deepcode-ci-bot found? |
…/PatternPedia/pattern-pedia-api into masterthesis/patternauthoringAPI
…nauthoringAPI # Conflicts: # README.md # src/main/java/com/patternpedia/api/rest/controller/PatternController.java # src/main/resources/application.properties
…s/patternauthoringAPI
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Merge for a stable version of the latexrendering component.