Features in settings default selection change #123
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Checks are failing, please fix them. |
manuwei
requested changes
Oct 14, 2021
src/app/core/directives/pattern-atlas-ui-repository-configuration.service.ts
Show resolved
Hide resolved
src/app/core/directives/pattern-atlas-ui-repository-configuration.service.ts
Outdated
Show resolved
Hide resolved
lharzenetter
requested changes
Oct 18, 2021
Member
lharzenetter
left a comment
lharzenetter
left a comment
There was a problem hiding this comment.
Please run the auto-formatter in each edited file.
src/app/app.component.ts
Outdated
| user: PAUser; | ||
| readonly pathConstants = globals.pathConstants; | ||
| loading = true; | ||
| readonly NOT_FOUND = 404; |
Member
There was a problem hiding this comment.
We could add these kind of constants into a dedicated constants file. Hence, we don't have to add it for each service (I guess it is used not only once?).
manuwei
reviewed
Oct 19, 2021
src/app/globals.ts
Outdated
| designModels: 'design-models' | ||
| } | ||
| }, | ||
| notFound : 404 |
Contributor
There was a problem hiding this comment.
I'd rename it to statusCodeNotFound
Contributor
Author
Renamed as suggested |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.