Skip to content

Conversation

@mar-be
Copy link
Contributor

@mar-be mar-be commented Jan 13, 2022

This pull request fixes the problem of setting the environment variables for the Docker container. Furthermore, the set values for the API URL and port are now also used.

Signed-off-by: Marvin Bechtold marvin.bechtold.dev@gmail.com

Signed-off-by: Marvin Bechtold <marvin.bechtold.dev@gmail.com>
@mar-be mar-be requested a review from lharzenetter January 13, 2022 09:00
@mar-be mar-be added the bug Something isn't working label Jan 13, 2022
Copy link
Member

@lharzenetter lharzenetter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Besides the comment, LGTM!

for key in $(jq .$topic /opt/init-config.d/*.json | jq -r 'keys[]'); do
myVal=$(jq -r [".$topic | .$key"] /opt/init-config.d/*.json | jq -r .[])
echo "saving: $topic/$key: $myVal"
# echo "saving: $topic/$key: $myVal"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why did you comment that out?

@lharzenetter lharzenetter merged commit 46713f7 into master Jan 13, 2022
@lharzenetter lharzenetter deleted the fix/env-vars branch January 13, 2022 13:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants