Skip to content

Conversation

@mar-be
Copy link
Contributor

@mar-be mar-be commented Jan 18, 2022

This PR adds the functionality to hide a section of a pattern if it has no content.

Signed-off-by: Marvin Bechtold marvin.bechtold.dev@gmail.com

Signed-off-by: Marvin Bechtold <marvin.bechtold.dev@gmail.com>
@mar-be mar-be requested review from lharzenetter and salmma January 18, 2022 15:37
Signed-off-by: Marvin Bechtold <marvin.bechtold.dev@gmail.com>
Copy link
Member

@lharzenetter lharzenetter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add semicolons at the line ends.

Signed-off-by: Marvin Bechtold <marvin.bechtold.dev@gmail.com>
Signed-off-by: Marvin Bechtold <marvin.bechtold.dev@gmail.com>
Copy link

@salmma salmma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lharzenetter lharzenetter merged commit 48d6856 into master Jan 20, 2022
@lharzenetter lharzenetter deleted the feature/hide-empty-sections branch January 20, 2022 08:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants