Fix/pattern navigation #83
Conversation
add a fallback on the patternlanguage / pattern page as an alternative to using the URI
…ing add relation relationtype dropdown
… MAP Pattern import
…e spacing" functionality
…ding enhanced icon support in the detail view
…raph Node delete functionality, Fixed several graphbugs and added graph qol improvements
DeepCode's analysis on #d29371 found:
Top issues
👉 View analysis in DeepCode’s Dashboard | Configure the bot |
manuwei
left a comment
manuwei
left a comment
There was a problem hiding this comment.
Looks good to me! I just added a few minor comments, mostly to improve overall code readability (not necessary written by you :) )
src/app/core/component/action-button-bar/action-button-bar.component.ts
Outdated
Show resolved
Hide resolved
src/app/core/component/create-pattern-relation/create-pattern-relation.component.ts
Outdated
Show resolved
Hide resolved
| return this.getPatternLanguageByEncodedUri(uri); | ||
| } | ||
|
|
||
| getEdgeTypes(): Observable<string[]> { |
There was a problem hiding this comment.
a short description why this is not implemented for pattern languages would be helpful... Because there actually is a type for edges - do we not need it here? I think showing the type for pattern languages/views (as we do for solutions) would be nice
src/app/pattern-language-management/create-pattern/create-pattern.component.ts
Outdated
Show resolved
Hide resolved
src/app/pattern-language-management/create-pattern/create-pattern.component.ts
Outdated
Show resolved
Hide resolved
...ern-language-management/pattern-language-management/pattern-language-management.component.ts
Outdated
Show resolved
Hide resolved
src/app/pattern-view-management/pattern-view-renderer/pattern-view-renderer.component.ts
Outdated
Show resolved
Hide resolved
…o date when deleting edges in the graph. Adding necessary services
…nter on patternview and fixing graph pattern info button routing
manuwei
left a comment
manuwei
left a comment
There was a problem hiding this comment.
The PR looks fine to me :) I added a few minor comments, you can resolve them and merge afterwards
| <ng-container *ngFor="let relation of directedPatternRelations"> | ||
| <p class="horiz-centered"> | ||
| <a [routerLink]="['..',relation.sourcePatternId]">{{ relation?.sourcePatternName}}</a> | ||
| <a [routerLink]="['..',relation.sourcePatternUri]">{{ relation?.sourcePatternName}}</a> |
There was a problem hiding this comment.
yes it was the reason for the error when routing via patternlinks and accessing the pattern via the info button in the graph.
Instead of accessing the pattern via: patternpedia/PL/Patternuri patternpedia/PL/P_ID got called - which does not exist
| return this.patternService.getPatternContentByPattern(this.patterns.find(it => it.id === toPattern)).pipe( | ||
| map((patterncontent) => { | ||
| const targetPatternContent = patterncontent.content; | ||
| // const targetPatternContent = patterncontent.content; |
There was a problem hiding this comment.
can we delete these two lines ?
There was a problem hiding this comment.
actually we could delete the whole mapping? ( map((pattercontent)...
src/app/core/default-pattern-renderer/default-pattern-renderer.component.ts
Outdated
Show resolved
Hide resolved
| } | ||
| const dataSubscription = dataObservable.subscribe(() => | ||
| this.cdr.detectChanges()); | ||
| const dataSubscription = getPatternObservable.subscribe(() => dataObservable.subscribe(() => |
There was a problem hiding this comment.
we should pipe those requests instead of subscribing in a subscribe...
Fully test graph functionality (a lot of bugs got fixed and features added)
Added edit icon/name (requires backend commit for namechange)
MAP Import support
Fixed add new pattern issue, where the markdown wouldnt get loaded
Check readthedocs