Skip to content

Conversation

@mbeisel
Copy link
Contributor

@mbeisel mbeisel commented Jan 28, 2021

  • Adding delete dialogs
  • Adding delete functionality for PLanguages, PViews and DesignModels
  • Unifying Card Style
  • Making Icons work for PatternViews

Requires backend branch: https://github.com/PatternAtlas/pattern-atlas-api/tree/fix/delete-functionality
Please Merge simulatinously

…iews and DesignModels, Unifying Card Style, Making Icons work for PatternViews
@mbeisel mbeisel requested a review from manuwei January 28, 2021 10:13
@mbeisel mbeisel self-assigned this Jan 28, 2021
@ghost
Copy link

ghost commented Jan 28, 2021

Congratulations 🎉. DeepCode analyzed your code in 503.427 seconds and we found no issues. Enjoy a moment of no bugs ☀️.

👉 View analysis in DeepCode’s Dashboard | Configure the bot

Copy link
Contributor

@manuwei manuwei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@manuwei
Copy link
Contributor

manuwei commented Jan 29, 2021

One tiny comment: after deleting a pattern in a pattern language, the overview of pattern languages still displays the old number of patterns for this language

@manuwei manuwei merged commit e62a249 into master Feb 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add confirm dialog for all delete buttons. No delete option for PL / PV / DM Icon URL of Pattern View is not stored and used

3 participants