Feature/markdown pattern references #97

manuwei · 2021-03-25T14:24:22Z

Allow pattern authors to reference other patterns within the description of a pattern via hyperlinks:

when creating a new pattern (via a new button that was added to the the markdown editor)
when editing a pattern (via a new select field in the editor-dialog)

This fixes #81

…own editor

…kdown-pattern-references # Conflicts: # src/app/core/core.module.ts # src/app/core/default-pl-renderer/default-pl-renderer.component.ts # src/app/pattern-language-management/create-pattern/create-pattern.component.ts

pattern language needs to be loaded first, because we need the pattern language object to load the pattern afterwards

ghost · 2021-03-25T14:24:40Z

Congratulations 🎉. DeepCode analyzed your code in 2.508 seconds and we found no issues. Enjoy a moment of no bugs ☀️.

👉 View analysis in DeepCode’s Dashboard | Configure the bot

mbeisel · 2021-04-30T08:22:59Z

Looks good!
I would just do some minor change regarding the look.

Add some spacing in between the dropdown and the add button
Test if it would look better, to put the dropdown to the right side of the title to save some space

Bumps [browserslist](https://github.com/browserslist/browserslist) from 4.12.0 to 4.16.6. - [Release notes](https://github.com/browserslist/browserslist/releases) - [Changelog](https://github.com/browserslist/browserslist/blob/main/CHANGELOG.md) - [Commits](browserslist/browserslist@4.12.0...4.16.6) Signed-off-by: dependabot[bot] <support@github.com>

ghost · 2021-05-25T14:59:12Z

Congratulations 🎉. DeepCode analyzed your code in 2.508 seconds and we found no issues. Enjoy a moment of no bugs ☀️.

👉 View analysis in DeepCode’s Dashboard | Configure the bot

ghost · 2021-05-25T14:59:33Z

DeepCode failed to analyze this pull request

Something went wrong despite trying multiple times, sorry about that.
Please comment this pull request with "Retry DeepCode" to manually retry, or contact us so that a human can look into the issue.

ghost · 2021-05-25T14:59:59Z

Congratulations 🎉. DeepCode analyzed your code in 2.508 seconds and we found no issues. Enjoy a moment of no bugs ☀️.

👉 View analysis in DeepCode’s Dashboard | Configure the bot

ghost · 2021-05-25T15:00:20Z

DeepCode failed to analyze this pull request

Something went wrong despite trying multiple times, sorry about that.
Please comment this pull request with "Retry DeepCode" to manually retry, or contact us so that a human can look into the issue.

ghost · 2021-05-25T15:00:46Z

Congratulations 🎉. DeepCode analyzed your code in 2.508 seconds and we found no issues. Enjoy a moment of no bugs ☀️.

👉 View analysis in DeepCode’s Dashboard | Configure the bot

ghost · 2021-05-25T15:01:06Z

DeepCode failed to analyze this pull request

Something went wrong despite trying multiple times, sorry about that.
Please comment this pull request with "Retry DeepCode" to manually retry, or contact us so that a human can look into the issue.

manuwei · 2021-05-25T15:08:24Z

Retry DeepCode

ghost · 2021-05-25T15:08:35Z

Congratulations 🎉. DeepCode analyzed your code in 0.598 seconds and we found no issues. Enjoy a moment of no bugs ☀️.

👉 View analysis in DeepCode’s Dashboard | Configure the bot

ghost · 2021-05-25T15:10:25Z

Congratulations 🎉. DeepCode analyzed your code in 4.799 seconds and we found no issues. Enjoy a moment of no bugs ☀️.

👉 View analysis in DeepCode’s Dashboard | Configure the bot

👉 The DeepCode service and API will be deprecated in August, 2021. Here is the information how to migrate. Thank you for using DeepCode 🙏 ❤️ !

If you are using our plugins, you might be interested in their successors: Snyk's JetBrains plugin and Snyk's VS Code plugin.

…list-4.16.6' into feature/markdown-pattern-references

…kdown-pattern-references # Conflicts: # src/app/core/component/cardrenderer/card-renderer.component.ts # src/app/core/core.module.ts # src/app/pattern-language-management/create-pattern/create-pattern.component.ts # src/app/pattern-language-management/pattern-language-management/pattern-language-management.component.ts # src/app/pattern-view-management/pattern-view-management/pattern-view-management.component.ts # src/app/pattern-view-management/pattern-view-renderer/pattern-view-renderer.component.ts

manuwei · 2021-06-07T14:18:09Z

@mbeisel could you recheck the changes? besides the css changes, it's mostly whitespace :)

… not exist bug

Manuela Weigold added 8 commits March 24, 2021 14:43

add button + functionaliaty to reference another pattern in the markd…

defe14f

…own editor

refactor getData method

6fcb7f9

pattern language needs to be loaded first, because we need the pattern language object to load the pattern afterwards

load pattern language by either ID or URI when creating a pattern

c824054

use id instead of URI for navigation

058f4a3

refactoring

9c6c619

refactoring: move markdowneditor logic to its own class

658a484

enable to add href references to pattern when editing a pattern

df7c842

manuwei requested a review from mbeisel March 25, 2021 14:24

Manuela Weigold added 2 commits March 25, 2021 15:27

fix minor deep code issues + whitespace

c05512c

fix more deep code issues

1a2fc77

dependabot bot and others added 4 commits May 25, 2021 01:55

add css

9fbf8b9

fix lint errors

7bdbfb7

remove unused tests

fe11111

remove unused test

62e0adf

Manuela Weigold added 3 commits May 26, 2021 09:04

comply to lint rules

cd80455

Merge remote-tracking branch 'origin/dependabot/npm_and_yarn/browsers…

1d8efae

…list-4.16.6' into feature/markdown-pattern-references

fix typo

6a6ed36

mbeisel and others added 2 commits June 7, 2021 17:05

Changing this.pattern.id to this.patternId to prevent pattern.id does…

1f9d29d

… not exist bug

remove test log

d72b067

mbeisel merged commit 75d31c8 into master Jun 9, 2021

Feature/markdown pattern references #97

Feature/markdown pattern references #97

Uh oh!

Conversation

manuwei commented Mar 25, 2021

Uh oh!

ghost commented Mar 25, 2021 • edited by ghost Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

👉 View analysis in DeepCode’s Dashboard | Configure the bot

Uh oh!

mbeisel commented Apr 30, 2021

Uh oh!

ghost commented May 25, 2021

👉 View analysis in DeepCode’s Dashboard | Configure the bot

Uh oh!

ghost commented May 25, 2021

DeepCode failed to analyze this pull request

Uh oh!

ghost commented May 25, 2021

👉 View analysis in DeepCode’s Dashboard | Configure the bot

Uh oh!

ghost commented May 25, 2021

DeepCode failed to analyze this pull request

Uh oh!

ghost commented May 25, 2021

👉 View analysis in DeepCode’s Dashboard | Configure the bot

Uh oh!

ghost commented May 25, 2021

DeepCode failed to analyze this pull request

Uh oh!

manuwei commented May 25, 2021

Uh oh!

ghost commented May 25, 2021 • edited by ghost Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

👉 View analysis in DeepCode’s Dashboard | Configure the bot

Uh oh!

ghost commented May 25, 2021 • edited by ghost Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

👉 View analysis in DeepCode’s Dashboard | Configure the bot

👉 The DeepCode service and API will be deprecated in August, 2021. Here is the information how to migrate. Thank you for using DeepCode 🙏 ❤️ !

Uh oh!

manuwei commented Jun 7, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

ghost commented Mar 25, 2021 •

edited by ghost

Loading

ghost commented May 25, 2021 •

edited by ghost

Loading

ghost commented May 25, 2021 •

edited by ghost

Loading