Add pat-fullscreen support for close #671
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A second pattern ``pat-fullscreen-close`` which is triggered on ``close-fullscreen`` CSS class allows for closing the fullscreen with custom buttons.
thet
commented
Sep 24, 2019
| ], function(Base, screenful) { | ||
| return Base.extend({ | ||
| name: "fullscreen-close", | ||
| trigger: ".close-fullscreen", |
There was a problem hiding this comment.
Attention: this is against the convention of using the pattern name pat-fullscreen-close as trigger. But since this makes only sense in the context of this fullscreen pattern this might be OK.
|
Why is this a second Pattern? It’s part of the same interaction pattern.
… Op 24 sep. 2019, om 11:07 heeft Johannes Raggam ***@***.***> het volgende geschreven:
A second pattern pat-fullscreen-close which is triggered on close-fullscreen CSS class allows for closing the fullscreen with custom buttons.
You can view, comment on, or merge this pull request online at:
#671 <#671>
Commit Summary
Add pat-fullscreen-close pattern
File Changes
M CHANGES.md <https://github.com/Patternslib/Patterns/pull/671/files#diff-0> (1)
M src/pat/fullscreen/documentation.md <https://github.com/Patternslib/Patterns/pull/671/files#diff-1> (5)
A src/pat/fullscreen/fullscreen-close.js <https://github.com/Patternslib/Patterns/pull/671/files#diff-2> (20)
M src/pat/fullscreen/fullscreen.js <https://github.com/Patternslib/Patterns/pull/671/files#diff-3> (10)
M src/pat/fullscreen/tests.js <https://github.com/Patternslib/Patterns/pull/671/files#diff-4> (5)
M src/patterns.js <https://github.com/Patternslib/Patterns/pull/671/files#diff-5> (1)
M webpack/base.config.js <https://github.com/Patternslib/Patterns/pull/671/files#diff-6> (1)
Patch Links:
https://github.com/Patternslib/Patterns/pull/671.patch <https://github.com/Patternslib/Patterns/pull/671.patch>
https://github.com/Patternslib/Patterns/pull/671.diff <https://github.com/Patternslib/Patterns/pull/671.diff>
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub <#671?email_source=notifications&email_token=AAFUKKJU2IJB345VNOQJ2ZDQLHKEPA5CNFSM4IZ44NDKYY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4HNID6XA>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAFUKKPDWMG32D7S77IX37DQLHKEPANCNFSM4IZ44NDA>.
|
|
@cornae the close-fullscreen event handler is initialized before you inject any slides. So, after injection, the event handler is not applied. But the injection pattern re-scans the injected dom tree for any patterns and initializes them. Therefore the close-button needs to be in a own pattern. |
pilz
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A second pattern
pat-fullscreen-closewhich is triggered onclose-fullscreenCSS class allows for closing the fullscreen with custom buttons.