Fix scrolling behavior, add getCSSValue #694
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thet
force-pushed
the
FLOW-912
branch
2 times, most recently
from
755c956 to
063194e
Compare
Fix scrolling behavior - whole page was scrolling when using Element.scrollIntoView() Add ``utils.getCSSValue`` for retrieving CSS property values for DOM nodes.
pilz
added a commit
that referenced
this pull request
Nov 28, 2019
#694 followup: pat-inject scrolling fixes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix scrolling behavior - whole page was scrolling when using Element.scrollIntoView().
Add
utils.getCSSValuefor retrieving CSS property values for DOM nodes.Upgrade moment to avoid duplicate dependencies.