Fix initial load for transition: css #718
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… on init (same as on change) this will add the class visible on items that should be shown and hidden on items that should be hidden. Hence the behaviour will work on initial load.
|
Thank you for the pull request! We'll look at it on friday. |
|
I can see that most of the black magic setting classes and styles are not done in the pat depends pattern. So to solve the additional issues mentioned by Cornelis, we need to investigate deeper into jQuery. For now I don't see any harm with this and will merge so that Cornelis can continue testing, but we will need to expand that pattern to address the issues mentioned in #719. NB that there is no support in depends.js for transition:css. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The class visible or hidden was never set in the on init method.
To fix I use the hideOrShow utils method in the on init instead of calling the show/hide methods.
Subsequently we call the updateModal method which was otherwise called in the show/hide methods. these two methods will now no longer be used and therefore removed.