pat-scroll-box - new pattern out of scrolling-detection #727
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Wat is pat-scrolling-box? Didn't we we go for pat-scroll-box as the name of the pattern? If pat-scrolling-box is something that supports pat-scroll-box, shouldn't we call it something else so that we keep the pat- prefix for things that are (interaction) patterns? |
thet
force-pushed
the
pat-scroll-box
branch
2 times, most recently
from
ba5c81b to
6a1023a
Compare
|
that was just a typo - i corrected it. |
|
Ok! |
…vious "scroll detection" module.
thet
changed the title
This was referenced May 28, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
pat-scroll-box: New pattern for scrolling detection.
Replaces the previous "scroll detection" module.