fix rebaseURL to work only with correct base URLs #732
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… doesn't start with an URL scheme.
thet
commented
Jun 22, 2020
| if ( | ||
| base.indexOf("://") !== -1 || | ||
| base[0] === "/" | ||
| ) { |
There was a problem hiding this comment.
mainly for performance reasons - if there is no correct base url there is no need to parse the HTML tree
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
core/utils rebaseURL: Do not rebase if the base URL isn't absolute or doesn't start with an URL scheme.
Note: the method
_rebaseHTML_via_HTMLParseris unused.I will remove this method and
lib/htmlparserin #731