end date should update when changing start date #739
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thet
changed the title
pat date picker: Remove ``format`` argument and just use the ISO 8601 standard "YYYY-MM-DD", like the specification of date inputs defines it. Format would have submitted a formatted value where the ISO standard is expected. This also allows for removing the dependency of ``pat-date-picker`` on MomentJS.
thet
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ready to review.
Works as we discussed it:
When "date input A" depends on "date input B" via the
afterargument the following happens:@pilz - I have the feeling that my wording in the documentation is a bit clumsy. I'd happy for improvements.
See the example in index.html on how to use it.
Special feature: It should work with multiple "after" dependencies - so if the
afterselector matches multiple other input fields, it should update for each of them.When starting this branch with
make servethere are two new inputs at the end of this page, configured with an offset of 2 days:http://0.0.0.0:3001/src/pat/date-picker/
Also I've updated the pat-validation demo with this feature:
planning-end updates when planning-start > planning-end but can still be set to a wrong date.