Skip to content

Conversation

thet
Copy link
Member

@thet thet commented Aug 10, 2020

The HTML5 specs allow for an required attribute without a value. We're not supporting this in pat-validation until now. This PR fixes this.

Now we can use:

<input type="text" name="req1" required="required" />

as well as

<input type="text" name="req1" required />

See:
https://html.spec.whatwg.org/multipage/input.html#attr-input-required
https://developer.mozilla.org/en-US/docs/Web/HTML/Attributes/required

@thet thet requested review from pysailor and reinhardt August 10, 2020 17:30
@thet thet force-pushed the pat-validation-required branch from 03cd6b8 to 11fa897 Compare August 10, 2020 17:37
Copy link
Contributor

@pysailor pysailor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks sane to me. The one failing test does not seem related (pat-tooltip: When a tooltip is clicked, if the 'source' parameter is 'content'…).
But I don't know how to trigger re-running the tests via a GH comment.

@pysailor
Copy link
Contributor

pysailor commented Aug 11, 2020

But I don't know how to trigger re-running the tests via a GH comment.

Of course, directly in travis, this is possible. I just restarted the build

@pysailor pysailor merged commit c5ccddc into master Aug 11, 2020
@pysailor pysailor deleted the pat-validation-required branch August 11, 2020 07:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants