Include hidden input.pat-autosuggest in validation #749
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
reinhardt
force-pushed
the
683-fix-validation-autosuggest
branch
from
1ec3d6f to
976a7a4
Compare
reinhardt
commented
Aug 25, 2020
| '<form class="pat-validation">'+ | ||
| '<input type="hidden" name="name" class="pat-autosuggest" data-pat-autosuggest="words: one, two">'+ | ||
| '</form>'); | ||
| $el.submit(); |
There was a problem hiding this comment.
Do we need another pattern.init($el) here?
There was a problem hiding this comment.
good catch, yes it does. checked it and added it myself.
There was a problem hiding this comment.
If yes then we probably also need it in the previous test which I copied this from...
thet
force-pushed
the
683-fix-validation-autosuggest
branch
2 times, most recently
from
1ea4a06 to
5ff0c25
Compare
thet
force-pushed
the
683-fix-validation-autosuggest
branch
from
5ff0c25 to
89cd4fa
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #683