Updates to pat-tooltip #756
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
thet
commented
Sep 21, 2020
thet
commented
- Restore old behavior of "source: content" where it only uses the triggers content and not another DOM structure.
- Remove "source: auto" (See: https://github.com/quaive/ploneintranet.prototype/issues/859#issuecomment-695997028 )
thet
force-pushed
the
pat-tooltip-updates
branch
from
738d1c8 to
86b0f7f
Compare
Use "source: ajax" also for getting the tooltip content from the current DOM as well as getting it from remote sources.
…t be used as it is not explicit enough and would lead to unintuitive behavior.
thet
force-pushed
the
pat-tooltip-updates
branch
from
86b0f7f to
f4911b5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.