Do not autofocus in iframes + other fixes. #778
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thet
commented
Nov 11, 2020
| setFocus(target) { | ||
| const $all = $(target); | ||
| const visible = [...$all].filter((it) => $(it).is(":visible")); | ||
| const empty = visible.filter((it) => it.value === ""); |
There was a problem hiding this comment.
@pilz: this fix is for the documented behavior (in documentation.md + the index.html) to not autofocus if the input is not empty and there is another autofocus element.
thet
commented
Nov 11, 2020
src/pat/autofocus/autofocus.js
Outdated
| // setFocus normally operates on the whole DOM anyways and if scoped | ||
| // (via the event handler in init) the last one wins. | ||
| // This is OK since only one element can have the focus. | ||
| clearTimeout(scheduled_task); |
There was a problem hiding this comment.
@pilz this is an optimization to call focus() only once and not multiple times for each pat-autofocus element which can be found in the DOM.
thet
commented
Nov 11, 2020
| $visible.get(0) && $visible.get(0).focus(); | ||
| }, 10); | ||
|
|
||
| if (!registered_event_handler) { |
There was a problem hiding this comment.
@pilz: We want the global event handler registered only once.
thet
commented
Nov 11, 2020
| export default autofocus; | ||
| setFocus(target) { | ||
| // Exit if task is scheduled. setFocus operates on whole DOM anyways. | ||
| if (scheduled_task) { |
There was a problem hiding this comment.
@pilz: If there is already a setFocus task scheduled, exit. No need to do it multiple times as this method operates on the whole DOM tree and is not scoped for the element itself.
thet
commented
Nov 11, 2020
|
|
||
| init: function init() { | ||
| init() { | ||
| if (window.self !== window.top) { |
…d element, if there is another autofocus element which is empty.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Plus: