pat calendar: Do not modify original event sources config. #780
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lem with doubling up events when visiting different fullcalendar pages with different urls via pat-inject
thet
commented
Nov 16, 2020
| } | ||
|
|
||
| const sources = opts.event.sources || []; | ||
| const sources = [...(opts.event.sources || [])]; |
There was a problem hiding this comment.
this is the actual fix - this copies the values instead of referencing them.
thet
commented
Nov 16, 2020
| parser.addArgument("url", null); | ||
| parser.addArgument("event-sources", [], undefined, true); | ||
| parser.addArgument("event-sources-classes", [], undefined, true); | ||
| parser.addArgument("event-sources-active", [], undefined, true); |
There was a problem hiding this comment.
I removed this as this is a too complicated way for an early idea on how to configure multiple calendars. Removed that and simplified the code below a bit.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes problem with doubling up events when visiting different fullcalendar pages with different urls via pat-inject.