Skip to content

Conversation

@albi3ro
Copy link
Contributor

@albi3ro albi3ro commented Oct 22, 2025

Context:

Description of the Change:

from_plxpr.py was getting complicated, so I moved the qfunc interpreter into its own file.

Benefits:

improved organization

Possible Drawbacks:

Related GitHub Issues:

Copy link
Member

@paul0403 paul0403 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Beautiful 💯

@codecov
Copy link

codecov bot commented Oct 22, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 97.46%. Comparing base (28e892e) to head (5b58c07).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2142      +/-   ##
==========================================
+ Coverage   97.39%   97.46%   +0.06%     
==========================================
  Files          91       92       +1     
  Lines       10610    10613       +3     
  Branches      999      998       -1     
==========================================
+ Hits        10334    10344      +10     
+ Misses        218      212       -6     
+ Partials       58       57       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Contributor

@mehrdad2m mehrdad2m left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks Good. I found the reason for one of the codecov complains. not sure about the other. They are probably ignored complains of past that are coming back to life as the new file is created.

@albi3ro albi3ro merged commit 8a37a53 into main Oct 22, 2025
38 checks passed
@albi3ro albi3ro deleted the split-from-plxpr-file branch October 22, 2025 19:46
lazypanda10117 pushed a commit that referenced this pull request Oct 28, 2025
**Context:**

**Description of the Change:**

`from_plxpr.py` was getting complicated, so I moved the qfunc
interpreter into its own file.

**Benefits:**

improved organization

**Possible Drawbacks:**

**Related GitHub Issues:**
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants