-
Notifications
You must be signed in to change notification settings - Fork 57
Split from_plxpr into two files
#2142
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Beautiful 💯
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2142 +/- ##
==========================================
+ Coverage 97.39% 97.46% +0.06%
==========================================
Files 91 92 +1
Lines 10610 10613 +3
Branches 999 998 -1
==========================================
+ Hits 10334 10344 +10
+ Misses 218 212 -6
+ Partials 58 57 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks Good. I found the reason for one of the codecov complains. not sure about the other. They are probably ignored complains of past that are coming back to life as the new file is created.
**Context:** **Description of the Change:** `from_plxpr.py` was getting complicated, so I moved the qfunc interpreter into its own file. **Benefits:** improved organization **Possible Drawbacks:** **Related GitHub Issues:**
Context:
Description of the Change:
from_plxpr.pywas getting complicated, so I moved the qfunc interpreter into its own file.Benefits:
improved organization
Possible Drawbacks:
Related GitHub Issues: