Skip to content

make s3 upload work #149

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 17, 2017
Merged

make s3 upload work #149

merged 1 commit into from
May 17, 2017

Conversation

@islue
Copy link
Contributor

@islue islue commented May 16, 2017

Try to fix it in minimum changes.

  1. several syntax errors fixed.
  2. replace hostname with region which is more familar for aws user, IMO
  3. keep local backup path and s3 destination path the same dir structure.
  4. several other monkey patches with comment inline.

@timvaillancourt
Copy link
Contributor

Thanks for fixing this @islue. As you can see the S3 code didn't have enough testing 😄

@timvaillancourt timvaillancourt self-assigned this May 17, 2017
@timvaillancourt timvaillancourt requested a review from dbmurphy May 17, 2017 14:17
@timvaillancourt timvaillancourt merged commit 93af5d6 into Percona-Lab:master May 17, 2017
@islue islue deleted the s3_uploader branch May 18, 2017 07:39
@timvaillancourt timvaillancourt mentioned this pull request May 18, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dbmurphy dbmurphy Awaiting requested review from dbmurphy

1 more reviewer

@timvaillancourt timvaillancourt timvaillancourt approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@timvaillancourt timvaillancourt

Labels

bug

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@islue @timvaillancourt