Skip to content

Conversation

@timvaillancourt
Copy link
Contributor

@timvaillancourt timvaillancourt commented May 17, 2017

If the tool hits the exception handler in Main.py we do not send a 'failed' state in the Notify NSCA method(!). Instead we are sending a success (Nagios state: OK).

  1. Start 'Notifier' component at init-time instead of the starting of the backup so we can react to any failure properly. Moved to it's own method .setup_notifier() in Main.py.
  2. Fixed incorrect fields passed into Notify on failure in Main.py .cleanup_on_failure().
  3. Added more detail to failure message string.
  4. Catch exceptions properly in Notify/Notify.py.
  5. Remove 'timer' start/stop and 'completed' boolean in Notify/Notify.py - it's already handled by 'Stage'.

@timvaillancourt timvaillancourt requested a review from dbmurphy May 17, 2017 17:11
@timvaillancourt timvaillancourt merged commit 5356005 into Percona-Lab:master May 18, 2017
@timvaillancourt timvaillancourt deleted the notify_no_fail branch May 18, 2017 14:13
@timvaillancourt timvaillancourt mentioned this pull request May 18, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants