Skip to content

1.0.4: Mongodump handle error #176

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jun 19, 2017
Merged

1.0.4: Mongodump handle error #176

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
f3c1965
Fix disabling of oplog tailer
timvaillancourt Jun 18, 2017
3152e56
Merge remote-tracking branch 'upstream/1.0.4' into 1.0.4
timvaillancourt Jun 19, 2017
93f8938
Handle mongodump's "Failed: ..." messages as a proper error
timvaillancourt Jun 19, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 15 additions & 0 deletions mongodb_consistent_backup/Backup/Mongodump/MongodumpThread.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,7 @@ def __init__(self, state, uri, timer, config, base_dir, version, threads=0, dump

self.timer_name = "%s-%s" % (self.__class__.__name__, self.uri.replset)
self.exit_code = 1
self.error_message = None
self._command = None
self.do_stdin_passwd = False
self.stdin_passwd_sent = False
Expand Down Expand Up @@ -76,6 +77,17 @@ def handle_password_prompt(self):
self._process.stdin.flush()
self.stdin_passwd_sent = True

def is_failed_line(self, line):
if line and line.startswith("Failed: "):
return True
return False

def handle_failure(self, line):
self.error_message = line.replace("Failed: ", "").capitalize()
logging.error("Mongodump error: %s" % self.error_message)
self.exit_code = 1
self.close()

def wait(self):
try:
while self._process.stderr:
Expand All @@ -88,6 +100,9 @@ def wait(self):
continue
elif self.is_password_prompt(read):
self.handle_password_prompt()
elif self.is_failed_line(read):
self.handle_failure(read)
break
else:
logging.info(line)
if self._process.poll() != None:
Expand Down