Skip to content

1.2.0: Fix for replication.max_lag_secs Issue #177 #218

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Sep 20, 2017
Merged

1.2.0: Fix for replication.max_lag_secs Issue #177 #218

merged 3 commits into from
Sep 20, 2017

Conversation

@timvaillancourt
Copy link
Contributor

@timvaillancourt timvaillancourt commented Sep 13, 2017 •
edited
Loading

  1. Make sure the score multiplier is a float. It breaks when using numbers larger than 10 (1.0.3: Setting replication.max_lag_secs in YAML-config causes Replset:find_secondary to have score '0' for all nodes #177).
  2. Throw exception if the winning backup secondary has score zero/0 to prevent any other issues selecting the wrong node in the future.
  3. Create constants for MongoDB replset state integers to clean up code.

Resolves issue #177.

@timvaillancourt timvaillancourt added this to the 1.2.0 milestone Sep 13, 2017
@timvaillancourt timvaillancourt mentioned this pull request Sep 13, 2017
Closed
@dbmurphy dbmurphy merged commit ea5626a into Percona-Lab:master Sep 20, 2017
@timvaillancourt timvaillancourt deleted the 1.2.0-issue_177 branch September 20, 2017 17:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@dbmurphy dbmurphy dbmurphy approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@timvaillancourt @dbmurphy