-
Notifications
You must be signed in to change notification settings - Fork 2
PMM-7 Fix Valkey Deployment #168
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ona-Lab/qa-integration into PMM-7-Fix-valkey-deployment
peterSirotnak
approved these changes
Oct 31, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request introduces support for deploying both Valkey Native Cluster and Valkey Sentinel topologies in the PMM QA framework, along with improvements to configuration and monitoring. The main changes include dynamic selection of the deployment playbook, the addition of a new cluster setup playbook, and enhancements to configuration files and monitoring commands.
Valkey Cluster and Sentinel Deployment Enhancements:
setup_valkeyto choose between cluster and sentinel playbooks based on theSETUP_TYPEparameter, and includedSETUP_TYPEin the environment variables.valkey-cluster.yml, for deploying a Valkey Native Cluster with multiple primaries and replicas, including container setup, configuration, cluster creation, PMM client installation, monitoring, and sample data seeding.valkey.ymlplaybook tovalkey-sentinel.ymland updated it for consistency and to support explicit sentinel deployment.Configuration Improvements:
valkey-primary.conf.j2andvalkey-replica.conf.j2templates to enable cluster mode, configure cluster files and timeouts, and enable append-only persistence for both cluster and sentinel setups. [1] [2]Container and Monitoring Enhancements: