Skip to content

Conversation

@travagliad
Copy link
Collaborator

This pull request introduces support for deploying both Valkey Native Cluster and Valkey Sentinel topologies in the PMM QA framework, along with improvements to configuration and monitoring. The main changes include dynamic selection of the deployment playbook, the addition of a new cluster setup playbook, and enhancements to configuration files and monitoring commands.

Valkey Cluster and Sentinel Deployment Enhancements:

  • Added dynamic selection in setup_valkey to choose between cluster and sentinel playbooks based on the SETUP_TYPE parameter, and included SETUP_TYPE in the environment variables.
  • Introduced a new Ansible playbook, valkey-cluster.yml, for deploying a Valkey Native Cluster with multiple primaries and replicas, including container setup, configuration, cluster creation, PMM client installation, monitoring, and sample data seeding.
  • Renamed the existing valkey.yml playbook to valkey-sentinel.yml and updated it for consistency and to support explicit sentinel deployment.

Configuration Improvements:

  • Updated valkey-primary.conf.j2 and valkey-replica.conf.j2 templates to enable cluster mode, configure cluster files and timeouts, and enable append-only persistence for both cluster and sentinel setups. [1] [2]
  • Ensured consistent use of double quotes for file and directory permissions in the sentinel playbook.

Container and Monitoring Enhancements:

  • Added unique hostnames to primary, replica, and sentinel containers for better identification and network isolation in both cluster and sentinel setups. [1] [2] [3]
  • Improved monitoring commands in the sentinel playbook for better readability and maintainability, and added sample data seeding steps to match the cluster playbook.

@travagliad travagliad merged commit 219c86f into v3 Oct 31, 2025
11 of 12 checks passed
@travagliad travagliad deleted the PMM-7-Fix-valkey-deployment branch November 3, 2025 12:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants