improve: fully refactor the sabr implementation

Author: ToddyTheNoobDud

package.json

@@ -17,6 +17,7 @@
     "@performanc/voice": "github:PerformanC/voice",
     "@toddynnn/symphonia-decoder": "1.0.6",
     "@toddynnn/voice-opus": "^1.0.1",
+    "jsdom": "^27.4.0",
     "mp4box": "^2.3.0",
     "myzod": "^1.12.1"
   },
@@ -30,4 +31,4 @@
   "optionalDependencies": {
     "prom-client": "^15.1.3"
   }
-}
+}

src/playback/player.js

@@ -590,6 +590,7 @@ export class Player {
       audioTrackId: this.track.audioTrackId
     }
     const urlData = await this.nodelink.sources.getTrackUrl(trackInfo)
+    if (!this.track) return false
     this.streamInfo = { ...urlData, trackInfo: this.track.info }
     logger('debug', 'Player', `Got track URL for guild ${this.guildId}`, {
       urlData
@@ -796,6 +797,7 @@ export class Player {
               audioTrackId: this.track.audioTrackId
             }
             const urlData = await this.nodelink.sources.getTrackUrl(trackInfo)
+            if (!this.track) return false
             this.streamInfo = { ...urlData, trackInfo: this.track.info }
             logger(
               'debug',
@@ -926,6 +928,7 @@ export class Player {
       audioTrackId: this.track.audioTrackId
     }
     const urlData = await this.nodelink.sources.getTrackUrl(trackInfo)
+    if (!this.track) return false
     this.streamInfo = { ...urlData, trackInfo: this.track.info }
 
     if (urlData.exception) {

src/sources/youtube/YouTube.js

@@ -232,7 +232,7 @@ async function _manageYoutubeHlsStream(
 
         if (res.error || res.statusCode !== 200) {
           if (res.stream) res.stream.destroy()
-          
+
           let retryCount = 0
           let success = false
           while (retryCount < 3 && !cancelSignal.aborted) {
@@ -978,7 +978,8 @@ export default class YouTubeSource {
   }
 
   async getTrackUrl(decodedTrack, itag) {
-    const clientList = this.config.clients.playback
+    let clientList = [...this.config.clients.playback]
+    clientList = ['Web', ...clientList.filter(c => c !== 'Web') || 'Android']
     const clientErrors = []
 
     for (const clientName of clientList) {
@@ -1012,6 +1013,16 @@ export default class YouTubeSource {
         }
 
         if (urlData.protocol === 'sabr') {
+          const bestAudio = urlData.formats
+            ?.filter((f) => f.mimeType?.includes('audio'))
+            .sort((a, b) => (b.bitrate || 0) - (a.bitrate || 0))[0]
+
+          if (bestAudio) {
+            urlData.format = bestAudio.mimeType?.includes('webm')
+              ? 'webm/opus'
+              : 'm4a'
+          }
+
           return urlData
         }
 
@@ -1176,15 +1187,45 @@ export default class YouTubeSource {
 
         const stream = new PassThrough()
 
-        sabr.on('data', (chunk) => stream.write(chunk))
+        sabr.on('data', (chunk) => {
+          if (!stream.write(chunk)) {
+            sabr.pause()
+          }
+        })
+        stream.on('drain', () => sabr.resume())
+
         sabr.on('end', () => stream.end())
-        sabr.on('error', (err) => {
+        sabr.on('error', async (err) => {
           logger('error', 'YouTube', `SABR stream error: ${err.message}`)
-          stream.destroy(err)
+
+          if ((err.message.includes('sabr.malformed_config') || err.message.includes('sabr.media_serving_enforcement_id_error')) && !isRecovering) {
+            logger('info', 'YouTube', `Known recoverable error detected (${err.message}), triggering stall recovery...`)
+            sabr.emit('stall')
+            return
+          }
+
+          if (!stream.destroyed) stream.destroy(err)
+        })
+
+        const originalDestroy = stream.destroy.bind(stream)
+        let isDestroying = false
+        stream.destroy = (err) => {
+          if (isDestroying) return
+          isDestroying = true
+          sabr.destroy(err)
+          this.activeStreams.delete(streamKey)
+          originalDestroy(err)
+        }
+
+        stream.once('close', () => {
+          if (isDestroying) return
+          isDestroying = true
+          sabr.destroy()
+          this.activeStreams.delete(streamKey)
         })
 
         const bestAudio = additionalData.formats.filter(f => f.mimeType?.includes('audio')).sort((a, b) => (b.bitrate || 0) - (a.bitrate || 0))[0]
-        
+
         sabr.start(bestAudio.itag)
 
         const type = bestAudio.mimeType?.includes('webm') ? 'webm/opus' : 'm4a'

src/sources/youtube/clients/Android.js

@@ -314,6 +314,46 @@ export default class Android extends BaseClient {
       return { exception: { message, severity: 'common', cause: 'Upstream' } }
     }
 
+    const streamingData = playerResponse.streamingData || playerResponse.streaming_data
+    const serverAbrUrl = streamingData?.serverAbrStreamingUrl || streamingData?.server_abr_streaming_url
+    const ustreamerConfig = playerResponse.playerConfig?.mediaCommonConfig?.mediaUstreamerRequestConfig?.videoPlaybackUstreamerConfig
+
+    if (serverAbrUrl) {
+      logger('debug', 'YouTube-Android', `SABR URL found for ${decodedTrack.identifier}. Using SABR protocol.`)
+
+      const formats = [...(streamingData.formats || []), ...(streamingData.adaptiveFormats || streamingData.adaptive_formats || [])].map(f => ({
+        itag: f.itag,
+        lastModified: f.lastModified || f.last_modified_ms,
+        xtags: f.xtags,
+        width: f.width,
+        height: f.height,
+        mimeType: f.mimeType || f.mime_type,
+        audioQuality: f.audioQuality || f.audio_quality,
+        bitrate: f.bitrate,
+        averageBitrate: f.averageBitrate || f.average_bitrate,
+        quality: f.quality,
+        qualityLabel: f.qualityLabel || f.quality_label,
+        audioTrackId: f.audioTrack?.id,
+        approxDurationMs: f.approxDurationMs || f.approx_duration_ms,
+        contentLength: f.contentLength || f.content_length,
+        isDrc: !!f.isDrc
+      }))
+
+      return {
+        protocol: 'sabr',
+        url: serverAbrUrl,
+        additionalData: {
+          serverAbrStreamingUrl: serverAbrUrl,
+          videoPlaybackUstreamerConfig: ustreamerConfig,
+          visitorData: this.getClient(context).client.visitorData,
+          clientInfo: { clientName: 3, clientVersion: '20.51.39' },
+          formats,
+          accessToken: null,
+          userAgent: this.getClient(context).client.userAgent
+        }
+      }
+    }
+
     return await this._extractStreamData(
       playerResponse,
       decodedTrack,

src/sources/youtube/clients/Web.js

@@ -5,12 +5,12 @@ import {
   buildTrack,
   checkURLType
 } from '../common.js'
-import { PoTokenManager } from '../potoke.js'
+import { poTokenManager } from '../potoke.js'
 
 export default class Web extends BaseClient {
   constructor(nodelink, oauth) {
     super(nodelink, 'WEB', oauth)
-    this.poTokenManager = new PoTokenManager()
+    this.poTokenManager = poTokenManager
   }
 
   getClient(context) {
@@ -255,7 +255,7 @@ export default class Web extends BaseClient {
     }
 
     const { poToken, visitorData } = await this.poTokenManager.generate(decodedTrack.identifier)
-    
+
     if (poToken) {
       const client = this.getClient(context)
       client.client.visitorData = visitorData
@@ -288,7 +288,7 @@ export default class Web extends BaseClient {
 
       try {
         const { body: playerResponse } = await makeRequest(
-          'https://youtubei.googleapis.com/youtubei/v1/player?prettyPrint=false', 
+          'https://youtubei.googleapis.com/youtubei/v1/player?prettyPrint=false',
           {
             method: 'POST',
             headers: {
@@ -310,7 +310,7 @@ export default class Web extends BaseClient {
 
         if (serverAbrUrl) {
           const playerScript = await cipherManager.getCachedPlayerScript()
-          
+
           let resolvedUrl = serverAbrUrl
           if (playerScript) {
             try {