Skip to content

Commit d79d169

Browse files
committed
pp_ctl.c: Comment on 2 exceptions in pp_goto()
Per discussion in GH #23969, neither of these two exceptions can be reached from our test suite. The exceptions address the possibility of a subroutine without a name, which is unlikely except possibly from XS code. The exceptions immediately preceding each of the two upon which we are commenting have messages composed to include a subroutine's name. These exceptions can be reached from our test suite and are covered as of the time of this commit.
1 parent 6ff96b9 commit d79d169

File tree

1 file changed

+4
-0
lines changed

1 file changed

+4
-0
lines changed

pp_ctl.c

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -3290,6 +3290,8 @@ PP(pp_goto)
32903290
gv_efullname3(tmpstr, gv, NULL);
32913291
DIE(aTHX_ "Goto undefined subroutine &%" SVf, SVfARG(tmpstr));
32923292
}
3293+
/* GH-23969: This exception should be retained because it can
3294+
* be reached from XS code. */
32933295
DIE(aTHX_ "Goto undefined subroutine");
32943296
}
32953297

@@ -3369,6 +3371,8 @@ PP(pp_goto)
33693371
DIE(aTHX_ "Goto undefined subroutine &%" SVf,
33703372
SVfARG(tmpstr));
33713373
}
3374+
/* GH-23969: This exception should be retained because it can
3375+
* be reached from XS code. */
33723376
DIE(aTHX_ "Goto undefined subroutine");
33733377
}
33743378

0 commit comments

Comments
 (0)