eb54d46f726 triggers new build-time warning

[jkeenan]

A recent commit has introduced a new build-time warning.

Using my customary configuration switches and clang10 as the compiler on FreeBSD-12, I built perl at 658a5be. I got the following build-time warning:

$ parse-build-warnings 658a5bedcf.freebsd.threaded.maketp.output.txt.gz
File:  658a5bedcf.freebsd.threaded.maketp.output.txt.gz

[
  {
    char   => 14,
    group  => "Wunused-variable",
    line   => 12662,
    source => "toke.c",
    text   => "unused variable 'syntax_error'",
  },
]

The line cited in toke.c was added in recent commit eb54d46:

commit eb54d46f7264ff7af62c409d8a6ab984a5a34f57 (HEAD)
Author:     Yves Orton <demerphq@gmail.com>
AuthorDate: Fri Aug 26 18:26:14 2022 +0200
Commit:     Yves Orton <demerphq@gmail.com>
CommitDate: Fri Sep 9 18:48:52 2022 +0200

    Stop parsing on first syntax error.

Configuring and building at that commit and the one immediately preceding that commit confirmed that it was the commit which first generated the warning.

@demerphq, can you take a look?

Thank you very much.
Jim Keenan

[jkeenan]

A recent commit has introduced a new build-time warning.

Using my customary configuration switches and clang10 as the compiler on FreeBSD-12, I built perl at 658a5be. I got the following build-time warning:

$ parse-build-warnings 658a5bedcf.freebsd.threaded.maketp.output.txt.gz
File:  658a5bedcf.freebsd.threaded.maketp.output.txt.gz

[
  {
    char   => 14,
    group  => "Wunused-variable",
    line   => 12662,
    source => "toke.c",
    text   => "unused variable 'syntax_error'",
  },
]

The line cited in toke.c was added in recent commit eb54d46:

commit eb54d46f7264ff7af62c409d8a6ab984a5a34f57 (HEAD)
Author:     Yves Orton <demerphq@gmail.com>
AuthorDate: Fri Aug 26 18:26:14 2022 +0200
Commit:     Yves Orton <demerphq@gmail.com>
CommitDate: Fri Sep 9 18:48:52 2022 +0200

    Stop parsing on first syntax error.

Configuring and building at that commit and the one immediately preceding that commit confirmed that it was the commit which first generated the warning.

@demerphq, can you take a look?

Thank you very much. Jim Keenan

This warning is still present in 534b663. Yves, @demerphq, could you take a look at it so that we can clear it up before tomorrow's release?

[demerphq]

On Mon, 19 Sept 2022, 13:13 James E Keenan, ***@***.***> wrote: A recent commit has introduced a new build-time warning. Using my customary configuration switches and clang10 as the compiler on FreeBSD-12, I built perl at 658a5be <658a5be>. I got the following build-time warning: $ parse-build-warnings 658a5be.freebsd.threaded.maketp.output.txt.gz File: 658a5be.freebsd.threaded.maketp.output.txt.gz [ { char => 14, group => "Wunused-variable", line => 12662, source => "toke.c", text => "unused variable 'syntax_error'", }, ] The line cited in toke.c was added in recent commit eb54d46 <eb54d46> : commit eb54d46 (HEAD) Author: Yves Orton ***@***.***> AuthorDate: Fri Aug 26 18:26:14 2022 +0200 Commit: Yves Orton ***@***.***> CommitDate: Fri Sep 9 18:48:52 2022 +0200 Stop parsing on first syntax error. Configuring and building at that commit and the one immediately preceding that commit confirmed that it was the commit which first generated the warning. @demerphq <https://github.com/demerphq>, can you take a look? Thank you very much. Jim Keenan This warning is still present in 534b663 <534b663>. Yves, @demerphq <https://github.com/demerphq>, could you take a look at it so that we can clear it up before tomorrow's release?

Sorry, no can do. I don't have compiler access until Thursday. It's used in debugging, if someone wants to PERL_DEB it then go ahead. Or just uncomment the commented out else if. It's not a bug, I don't think it should be a showstopper for a dev release. Yves

…