Build with -Accflags=-DNO_LOCALE_MESSAGES broke at recent commit

[jkeenan]

In the discussion for #21892 and #21895, I have mentioned that, in order to test the impact of those two pull requests, I have been trying to compile the "base case", i.e.,, the "before" situation. Per discussion with @khwilliamson, I should be able to build perl with this configuration:

$ sh ./Configure -des -Dusedevel -Accflags=-DNO_LOCALE_MESSAGES && make test_prep

I can build successfully on FreeBSD-13 but have repeatedly failed on Linux. The build failures typically end with something like this:

...
cc -fstack-protector-strong -L/usr/local/lib -o miniperl \
    opmini.o perlmini.o universalmini.o av.o builtin.o caretx.o class.o deb.o doio.o doop.o dquote.o dump.o globals.o gv.o hv.o keywords.o locale.o mathoms.o mg.o mro_core.o numeric.o pad.o peep.o perlio.o perly.o pp.o pp_ctl.o pp_hot.o pp_pack.o pp_sort.o pp_sys.o reentr.o regcomp.o regcomp_debug.o regcomp_invlist.o regcomp_study.o regcomp_trie.o regexec.o run.o scope.o sv.o taint.o time64.o toke.o utf8.o util.o   miniperlmain.o  -lpthread -ldl -lm -lcrypt -lutil -lc 
/usr/bin/ld: locale.o: in function `S_langinfo_sv_i':
locale.c:(.text+0x1cdc): undefined reference to `emulate_langinfo'
collect2: error: ld returned 1 exit status
make: *** [makefile:390: lib/buildcustomize.pl] Error 1

I decided to see if bisection would help. I used this invocation:

$ perl Porting/bisect.pl \
-Dcc=gcc -Accflags=-DNO_LOCALE_MESSAGES \
--start=v5.39.1 \
--end=af9733f1e2 \
--test-build

Bisection ended like this:

gcc -fstack-protector-strong -L/usr/local/lib -o miniperl \
    opmini.o perlmini.o universalmini.o av.o builtin.o caretx.o class.o deb.o doio.o doop.o dquote.o dump.o globals.o gv.o hv.o keywords.o locale.o mathoms.o mg.o mro_core.o numeric.o pad.o peep.o perlio.o perly.o pp.o pp_ctl.o pp_hot.o pp_pack.o pp_sort.o pp_sys.o reentr.o regcomp.o regcomp_debug.o regcomp_invlist.o regcomp_study.o regcomp_trie.o regexec.o run.o scope.o sv.o taint.o time64.o toke.o utf8.o util.o   miniperlmain.o  -lpthread -ldl -lm -lcrypt -lutil -lc 
/usr/bin/ld: locale.o: in function `S_langinfo_sv_i':
/home/jkeenan/gitwork/perl2/locale.c:6175: undefined reference to `emulate_langinfo'
collect2: error: ld returned 1 exit status
make: *** [Makefile:390: lib/buildcustomize.pl] Error 1
make: *** Waiting for unfinished jobs....
HEAD is now at e6145c9691 locale.c: Fix typo
bad - could not build test_prep

... and pointed to this commit:

commit e6145c96910698f2944584752f4fcde8e1ba3365 (HEAD, refs/bisect/bad)
Author:     Karl Williamson <khw@cpan.org>
AuthorDate: Mon Jan 22 14:19:53 2024 -0700
Commit:     Karl Williamson <khw@cpan.org>
CommitDate: Mon Jan 22 14:21:52 2024 -0700

    locale.c: Fix typo
    
    This #define has a trailing underscore

@khwilliamson, can you take a look? Thanks.

[khwilliamson]

I follow your directions, and yes it does not work in blead. But if I apply the three commits in #21903 then it works fine

[jkeenan]

I follow your directions, and yes it does not work in blead. But if I apply the three commits in #21903 then it works fine

I tested #21903 by extracting its 3 commits from the branch, applying each in turn to blead, configuring and building at each commit in 2 ways (my regular configuration and -Accflags=-DNO_LOCALE_MESSAGES), noting build success or failure, and logging any build-time warnings.

For those playing along at home ...

$ git checkout compile_emulate
$ git format-patch -o $P5P_DIR 0f9485cc78e57077433bdbe29fc9c4096361250f
# Created 3 patches
$ git checkout blead
$ git checkout -b gh-21903-khw-compile_emulate-exploration-20240130

# 0001
$ git am < $P5P_DIR/0001-C-preprocessor-doesn-t-understand-false-means-0.patch
$ sh ./Configure -des -Dusedevel && make test_prep 2>&1 | tee $P5P_DIR/make-output/`extract-sha`.linux.unthreaded.regular.maketp.output.txt
# build successful; no build-time warnings

$ git clean -dfxq
$ sh ./Configure -des -Dusedevel -Dcc=gcc -Accflags=-DNO_LOCALE_MESSAGES && make test_prep 2>&1 | tee $P5P_DIR/make-output/`extract-sha`.linux.unthreaded.no-locale-messages.maketp.output.txt
# build failed (as expected); 2 build-time warnings emitted prior to build failure:
$ report-build-warnings 7831a01a4a.linux.unthreaded.no-locale-messages.maketp.output.txt.gz 
File:  7831a01a4a.linux.unthreaded.no-locale-messages.maketp.output.txt.gz

  Wimplicit-function-declaration             1
  Wint-conversion                            1

# 0002
$ git clean -dfxq
$ git am < $P5P_DIR/0002-perl.h-Move-include-to-earlier.patch
$ sh ./Configure -des -Dusedevel && make test_prep 2>&1 | tee $P5P_DIR/make-output/`extract-sha`.linux.unthreaded.regular.maketp.output.txt
# build successful; no build-time warnings

$ git clean -dfxq
$ sh ./Configure -des -Dusedevel -Dcc=gcc -Accflags=-DNO_LOCALE_MESSAGES && make test_prep 2>&1 | tee $P5P_DIR/make-output/`extract-sha`.linux.unthreaded.no-locale-messages.maketp.output.txt
# build failed (as expected); 2 build-time warnings emitted prior to build failure:
$ report-build-warnings 47102e6798.linux.unthreaded.no-locale-messages.maketp.output.txt.gz 
File:  47102e6798.linux.unthreaded.no-locale-messages.maketp.output.txt.gz

  Wimplicit-function-declaration             1
  Wint-conversion                            1

# 0003
$ git clean -dfxq
$ git am < $P5P_DIR/0003-locale.c-Compile-call-S_emulate_langinfo-in-more-Con.patch
Applying: locale.c: Compile/call S_emulate_langinfo in more Configurations
$ sh ./Configure -des -Dusedevel && make test_prep 2>&1 | tee $P5P_DIR/make-output/`extract-sha`.linux.unthreaded.regular.maketp.output.txt
# build successful, but got 3 new build-time warnings
$ report-build-warnings 7d786c0271.linux.unthreaded.regular.maketp.output.txt.gz 
File:  7d786c0271.linux.unthreaded.regular.maketp.output.txt.gz

  Wunused-variable                           3

$ parse-build-warnings 7d786c0271.linux.unthreaded.regular.maketp.output.txt.gz 
File:  7d786c0271.linux.unthreaded.regular.maketp.output.txt.gz

[
  {
    char   => 9,
    group  => "Wunused-variable",
    line   => 6504,
    source => "locale.c",
    text   => "unused variable \xE2\x80\x98localeconv_klen\xE2\x80\x99",
  },
  {
    char   => 18,
    group  => "Wunused-variable",
    line   => 6503,
    source => "locale.c",
    text   => "unused variable \xE2\x80\x98localeconv_key\xE2\x80\x99",
  },
  {
    char   => 28,
    group  => "Wunused-variable",
    line   => 6502,
    source => "locale.c",
    text   => "unused variable \xE2\x80\x98cat_index\xE2\x80\x99",
  },
]

cc -c -DPERL_CORE -fwrapv -fno-strict-aliasing -pipe -fstack-protector-strong -I/usr/local/include -
D_LARGEFILE_SOURCE -D_FILE_OFFSET_BITS=64 -std=c99 -O2 -Wall -Werror=pointer-arith -Werror=vla -Wext
ra -Wno-long-long -Wno-declaration-after-statement -Wc++-compat -Wwrite-strings locale.c
locale.c: In function ‘S_emulate_langinfo’:
locale.c:6504:9: warning: unused variable ‘localeconv_klen’ [-Wunused-variable]
 6504 |     I32 localeconv_klen;
      |         ^~~~~~~~~~~~~~~
locale.c:6503:18: warning: unused variable ‘localeconv_key’ [-Wunused-variable]
 6503 |     const char * localeconv_key;
      |                  ^~~~~~~~~~~~~~
locale.c:6502:28: warning: unused variable ‘cat_index’ [-Wunused-variable]
 6502 |     locale_category_index  cat_index;
      |                            ^~~~~~~~~
$ make test_harness
# All tests successful.

$ git clean -dfxq
$ sh ./Configure -des -Dusedevel -Dcc=gcc -Accflags=-DNO_LOCALE_MESSAGES && make test_prep 2>&1 | tee $P5P_DIR/make-output/`extract-sha`.linux.unthreaded.no-locale-messages.maketp.output.txt
# build successful (at last!), but got same 3 build-time warnings as with regular configuration
$ report-build-warnings 7d786c0271.linux.unthreaded.no-locale-messages.maketp.output.txt.gz 
File:  7d786c0271.linux.unthreaded.no-locale-messages.maketp.output.txt.gz

  Wunused-variable                           3

[make-output] 2020 $ parse-build-warnings 7d786c0271.linux.unthreaded.no-locale-messages.maketp.output.txt.gz 
File:  7d786c0271.linux.unthreaded.no-locale-messages.maketp.output.txt.gz

[
  {
    char   => 9,
    group  => "Wunused-variable",
    line   => 6504,
    source => "locale.c",
    text   => "unused variable \xE2\x80\x98localeconv_klen\xE2\x80\x99",
  },
  {
    char   => 18,
    group  => "Wunused-variable",
    line   => 6503,
    source => "locale.c",
    text   => "unused variable \xE2\x80\x98localeconv_key\xE2\x80\x99",
  },
  {
    char   => 28,
    group  => "Wunused-variable",
    line   => 6502,
    source => "locale.c",
    text   => "unused variable \xE2\x80\x98cat_index\xE2\x80\x99",
  },
]

$ make test_harness
# All tests successful.

Given that the build-time failures I was getting with -Accflags=-DNO_LOCALE_MESSAGES were only appearing on Linux, I suspected that the failures were associated with recent modifications to locale.c that added Linux-specific locale categories. Of the 3 commits in #21903, only the third touches those Linux-specific locale categories, so it is not surprising that it is only once the third patch is applied that the build failures with -Accflags=-DNO_LOCALE_MESSAGES.

We should still try to figure out what it is about the Linux-specific locale categories that broke the build with -Accflags=-DNO_LOCALE_MESSAGES.

[jkeenan]

At commit 495831c I configured and built on Linux with:

$ sh ./Configure -des -Dusedevel -Accflags=-DNO_LOCALE_MESSAGES

I got no build-time warnings and all tests passed. Closing ticket.