Skip to content

skip trying to constant fold an incomplete op tree #18390

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 23, 2020
Merged

skip trying to constant fold an incomplete op tree #18390

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion op.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5595,7 +5595,7 @@ Perl_cmpchain_finish(pTHX_ OP *ch)
cmpop->op_private = 2;
cmpop = CHECKOP(cmpoptype, cmpop);
if(!cmpop->op_next && cmpop->op_type == cmpoptype)
cmpop = fold_constants(op_integerize(op_std_init(cmpop)));
cmpop = op_integerize(op_std_init(cmpop));
condop = condop ? newLOGOP(OP_CMPCHAIN_AND, 0, cmpop, condop) :
cmpop;
if (!nextrightarg)
Expand Down
17 changes: 10 additions & 7 deletions t/op/cmpchain.t
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,13 +14,6 @@ my @nceqop = qw(<=> cmp ~~);
my @chrelop = qw(< > <= >= lt gt le ge);
my @ncrelop = qw(isa);

plan tests => @nceqop*@nceqop + 2*@cheqop*@nceqop + 2*@cheqop*@cheqop*@nceqop +
@ncrelop*@ncrelop + 2*@chrelop*@ncrelop + 2*@chrelop*@chrelop*@ncrelop +

@cheqop*@cheqop + @chrelop*@chrelop +
@cheqop*@cheqop*@cheqop + @chrelop*@chrelop*@chrelop +
(9 + 6*9)*13;

foreach my $c0 (@nceqop) {
foreach my $c1 (@nceqop) {
is eval("sub { \$a $c0 \$b $c1 \$c }"), undef,
Expand Down Expand Up @@ -168,3 +161,13 @@ foreach(
"operand evaluation order";
}
}

# https://github.com/Perl/perl5/issues/18380
fresh_perl_is(<<'CODE', "", {}, "stack underflow");
no warnings "uninitialized";
my $v;
1 < $v < 2;
2 < $v < 3;
CODE

done_testing();