Smoke me/jkeenan/gh 21393 unused var #21408
Conversation
pp_ctl.c
Outdated
| SAVETMPS; | ||
| PUSHMARK(PL_stack_sp); | ||
| rpp_xpush_1(name_sv); /* always use the object for method calls */ | ||
| int count = call_sv(PL_hook__require__before, G_SCALAR); |
There was a problem hiding this comment.
While we're at it, the type of count should be changed from int to I32 because that's what call_sv returns.
|
Really the count variable and assertion should just be removed, and call_sv() be called without using it's return value. The code I changed had 'if (count && ...)', but call_sv(...,G_SCALAR) always returns 1. The assertion was just a temporary crutch to check that I wasn't changing behaviour when I removed the 'count > 0' check. |
jkeenan
force-pushed
the
smoke-me/jkeenan/gh-21293-unused-var
branch
from
32a5994 to
115a10b
Compare
jkeenan
changed the title
See latest version of this pull request. |
jkeenan
added
squash-before-merge
|
LGTM |
Implement Dave Mitchell's suggestion: we don't really need the unused variable. For: #21393
jkeenan
force-pushed
the
smoke-me/jkeenan/gh-21293-unused-var
branch
from
115a10b to
bc6e83c
Compare
This suppresses the
-Wunused_variablewarning reported in #21393 -- but since I'm just monkey-patching, please review.(You may get a porting test failure because (I think) Module-CoreList needs to be updated after today's release.)