Carp croak gh16827 20231029 #21603
Closed
Carp croak gh16827 20231029 #21603
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Two of these tests are failing, so this branch is not yet to be considered for merging. Chris Wagner is now a Perl author.
Per OP's suggestions in Perl#16815 (comment) This, however, triggers test failures in the newly added test file dist/Carp/t/Perlgh-16827-stash_deletion_new.t.
jkeenan
force-pushed
the
carp-croak-gh16827-20231029
branch
from
740dfba to
97e737c
Compare
Contributor
Author
|
In 97e737c I added code changes suggested by the OP back in 2019 when we were still using RT for issue tracking (#16815). Test failures resulted. I was only looking at the problem from the point of view of cleaning up loose ends from our RT->GH conversion. I had, and have, no strong feelings about the problems in Carp, so I'm not going to invest more time in this pull request. Closing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rebases an older branch on blead. Failing tests; do not merge; for research only.
See: #16815