Skip to content

Conversation

@tonycoz
Copy link
Contributor

@tonycoz tonycoz commented Sep 10, 2024

This was:

Peek.xs:415:1: warning: missing initializer for field ‘xop_dump’ of ‘XOP’ {aka ‘const struct custom_op’} [-Wmissing-field-initializers]
415 | };
| ^
In file included from ../../perl.h:4542,
from Peek.xs:3:
../../op.h:926:21: note: ‘xop_dump’ declared here
926 | void (*xop_dump)(pTHX_ const OP *o, struct Perl_OpDumpContext *ctx);
| ^~~~~~~~


  • This set of changes requires a perldelta entry, and it is included.
  • This set of changes requires a perldelta entry, and I need help writing it.
  • [ x] This set of changes does not require a perldelta entry.

This was:

Peek.xs:415:1: warning: missing initializer for field ‘xop_dump’ of ‘XOP’ {aka ‘const struct custom_op’} [-Wmissing-field-initializers]
  415 | };
      | ^
In file included from ../../perl.h:4542,
                 from Peek.xs:3:
../../op.h:926:21: note: ‘xop_dump’ declared here
  926 |     void          (*xop_dump)(pTHX_ const OP *o, struct Perl_OpDumpContext *ctx);
      |                     ^~~~~~~~
@jkeenan jkeenan added the build-time-warnings Replaces [META] Build-time warnings RT #133556 label Sep 10, 2024
@jkeenan
Copy link
Contributor

jkeenan commented Sep 10, 2024

The place where this warning began to be admitted was here:

commit 1eab73a91a97030ed9ce247321dea85de835f830
Author:     Paul Evans <leonerd@leonerd.org.uk>
AuthorDate: Fri Sep 6 18:35:47 2024
Commit:     Paul Evans <leonerd@leonerd.org.uk>
CommitDate: Mon Sep 9 05:38:25 2024

    Add xop_dump field and integrate into op_dump()

The patch clears up the warning.

@tonycoz tonycoz merged commit 2a59782 into Perl:blead Sep 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

build-time-warnings Replaces [META] Build-time warnings RT #133556

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants