Silence clang compilation warning #22660
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Commit 9acaa98 introduced a compilation warning that I only have seen with clang. Casting appropriately gets rid of it.
jkeenan
approved these changes
Oct 11, 2024
Contributor
jkeenan
left a comment
jkeenan
left a comment
There was a problem hiding this comment.
How I tested
$ sh ./Configure -des -Dusedevel -Dcc=clang-14 && make test_prep 2>&1 | \
tee $P5P_DIR/make-output/`extract-sha`.linux.unthreaded.clang-14.maketp.output.txt
Blead
$ report-build-warnings 9acaa9844a.linux.unthreaded.clang-14.maketp.output.txt.gz
File: 9acaa9844a.linux.unthreaded.clang-14.maketp.output.txt.gz
Wsign-compare 1
Pull Request
$ report-build-warnings e3baf5bb38.linux.unthreaded.clang-14.maketp.output.txt.gz
File: e3baf5bb38.linux.unthreaded.clang-14.maketp.output.txt.gz
jkeenan
added
the
build-time-warnings
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commit 9acaa98 introduced a compilation warning that I only have seen with clang. Casting appropriately gets rid of it.