sv_inline.h:Perl_new_sv: prevent unused parameter warnings #22807
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This would warn if you built with -DDEBUG_LEAKING_SCALARS and without
-DDEBUGGING and without -DPERL_MEM_LOG, since these enable the code
that actually uses the parameters.
sv_inline.h: In function 'Perl_new_sv':
sv_inline.h:72:31: warning: unused parameter 'file' [-Wunused-parameter]
72 | Perl_new_sv(pTHX_ const char *file, int line, const char *func)
| ~~~~~~~~~~~~^~~~
sv_inline.h:72:41: warning: unused parameter 'line' [-Wunused-parameter]
72 | Perl_new_sv(pTHX_ const char *file, int line, const char *func)
| ~~~~^~~~
sv_inline.h:72:59: warning: unused parameter 'func' [-Wunused-parameter]
72 | Perl_new_sv(pTHX_ const char *file, int line, const char *func)
| ~~~~~~~~~~~~^~~~
Fixes Perl#22806
jkeenan
added
the
build-time-warnings
khwilliamson
approved these changes
Dec 3, 2024
Contributor
|
I configured and built on FreeBSD-13 and Debian Linux 11 using both All build-time warnings cleared up. Ran the test suite on 2 of the 4 instances; PASS. In the commit message, the line beginning with |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This would warn if you built with -DDEBUG_LEAKING_SCALARS and without -DDEBUGGING and without -DPERL_MEM_LOG, since these enable the code that actually uses the parameters.
sv_inline.h: In function 'Perl_new_sv':
sv_inline.h:72:31: warning: unused parameter 'file' [-Wunused-parameter]
72 | Perl_new_sv(pTHX_ const char *file, int line, const char *func)
| ~~~~~~~~~~~~^~~~
sv_inline.h:72:41: warning: unused parameter 'line' [-Wunused-parameter]
72 | Perl_new_sv(pTHX_ const char *file, int line, const char *func)
| ~~~~^~~~
sv_inline.h:72:59: warning: unused parameter 'func' [-Wunused-parameter]
72 | Perl_new_sv(pTHX_ const char *file, int line, const char *func)
| ~~~~~~~~~~~~^~~~
Fixes #22806
TODO: fill description here
This set of changes does not require a perldelta entry.