Skip to content

Conversation

@jkeenan
Copy link
Contributor

@jkeenan jkeenan commented Aug 11, 2025

Consider this excerpt from dist/Filter-Simple/Makefile.PL:

  1 require 5.006; # uses 'our'
  2 use strict;
  3 use ExtUtils::MakeMaker;
  4 WriteMakefile(
  5     'NAME'          => 'Filter::Simple',
  6     'VERSION_FROM'  => 'lib/Filter/Simple.pm',
  7     'INSTALLDIRS'   => 'perl',
  8     'LICENSE'       => 'perl_5',
  9     'INSTALLDIRS'   => ( $] < 5.011 ? 'perl' : 'site' ),
...

Note that INSTALLDIRS gets assigned to twice, once at line 7 and once at line 9. This is potentially confusing to any future maintainer of this library or anyone who does a CPAN release.

Please review this pull request.

And speaking of CPAN releases ...

In blead, Filter-Simple is at version 0.96. Up on CPAN, it's still at version 0.94 and hasn't had a CPAN release since August 2017.

Update Changes for versions 0.95, 0.96 and current.
@jkeenan jkeenan requested review from atoomic and tonycoz August 11, 2025 22:02
@jkeenan jkeenan self-assigned this Aug 12, 2025
@jkeenan jkeenan merged commit 26d53a3 into blead Aug 12, 2025
68 checks passed
@jkeenan jkeenan deleted the smoke-me/jkeenan/filter-simple-makefile-pl-20250811 branch August 12, 2025 12:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants