pp_aasign: silence "var set but not used" warning #23689
Conversation
PERL_RC_STACK builds were giving this warning:
pp_hot.c:3147:21: warning: variable 'i' set but not used
[-Wunused-but-set-variable]
which was true: under that build, the i variable was being set but
not used in a couple of places (it's value is only used on
non-PERL_RC_STACK builds).
So avoid that var under PERL_RC_STACK builds.
I will test this out later today. |
|
We use C99 now, so I think it would make sense to move the declarations of |
Possibly, but I'd prefer to keep this commit as minimal as possible, to just address the issue at hand. |
jkeenan
added
the
build-time-warnings
jkeenan
left a comment
jkeenan
left a comment
There was a problem hiding this comment.
Configured and built with clang and -DPERL_RC_STACK on both Linux and FreeBSD; build-time warning gone. Also built with g++ and -DPERL_RC_STACK on Linux; this particular build-time warning was not emitted. Ready to merge.
| SV **svp; | ||
| #ifndef PERL_RC_STACK | ||
| SSize_t i; | ||
| #endif |
There was a problem hiding this comment.
When struggling with the build-time warning (as mentioned in #23661 (comment)), I got this far ...
| #else | ||
| for (i = 0, svp = relem; svp <= lastrelem; i++, svp++) | ||
| #endif | ||
| { |
There was a problem hiding this comment.
... but didn't realize I should have put this for loop statement inside an #ifdef ... #else ... #endif structure; below as well. Thanks.
PERL_RC_STACK builds were giving this warning:
which was true: under that build, the i variable was being set but not used in a couple of places (it's value is only used on non-PERL_RC_STACK builds).
So avoid that var under PERL_RC_STACK builds.