Don't warn about jumping into a construct if we're DIE-ing #23922
+14
−14
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There are many cases where we throw exceptions if you attempt to goto somewhere you have no business going. We'd *also* throw a deprecation warning in these cases, which just seems silly. Deprecated means "this will stop working eventually", so there's no need to throw that when we're just going to die right now.
wolfsage
force-pushed
the
fix-goto-warning
branch
from
71f977b to
8493142
Compare
Contributor
Thanks for taking a look at this. I hope to get to this Sunday or early next week. |
jkeenan
added a commit
to jkeenan/perl5
that referenced
this pull request
Nov 15, 2025
This branch explores the question: What if we accept Matt Horsfall's suggested revision in pp_ctl.c (GH Perl#23922) into blead, then accept the goto-label-fatal branch underlying p.r. GH Perl#23782 into blead? Once a couple of merge conflicts were revised, the result would configure and build but would fail two test files: op/goto.t (Wstat: 0 Tests: 75 Failed: 23) Failed tests: 53-75 uni/labels.t (Wstat: 0 Tests: 11 Failed: 1) Failed test: 10 The failures in t/op/goto.t would be not at all surprising. Those tests are tests which currently pass in blead but which would fail if the code changes in pp_ctl.c in 23782 were directly merged into blead. I first deleted those tests from t/op/goto.t, then added them back in so that we would have a tally of the ways in which 'goto LABEL' would *no longer* work. So if we first merged 23922, we would presumably re-work those 23 test to pass in an informative way. I'll need to look further into t/uni/labels.t.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are many cases where we throw exceptions if you attempt to goto somewhere you have no business going. We'd also throw a deprecation warning in these cases, which just seems silly. Deprecated means "this will stop working eventually", so there's no need to throw that when we're just going to die right now.
This probably warrants a changelog entry.
IMO, this could (should) be merged, and then #23782 could be built on this, changing the
deprecate_fatal_into a DIE() to match the other goto exceptions...